Skip to content

feat(discover2) Add public fields to discover for tracing #15959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2019
Merged

feat(discover2) Add public fields to discover for tracing #15959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7652a7
feat(discover2) Add public fields to discover for tracing
markstory Dec 5, 2019
5dc6a37
See if not waiting on the title makes this test more stable.
markstory Dec 5, 2019
92e5ea3
Attempt to stabilize test in another way.
markstory Dec 5, 2019
42bc748
Use contexts for span_id and trace_id as they are uuid/int in snuba and
markstory Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/sentry/snuba/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,28 @@ class Columns(Enum):
TRANSACTION_STATUS = Column(
None, None, "transaction_status", "transaction_status", "transaction.status"
)
# Tracing context fields.
TRACE_ID = Column(
"events.contexts[trace.trace_id]",
"contexts[trace.trace_id]",
"contexts[trace.trace_id]",
"contexts[trace.trace_id]",
"trace",
)
SPAN_ID = Column(
"events.contexts[trace.span_id]",
"contexts[trace.span_id]",
"contexts[trace.span_id]",
"contexts[trace.span_id]",
"trace.span",
)
PARENT_SPAN_ID = Column(
None,
None,
"contexts[trace.parent_span_id]",
"contexts[trace.parent_span_id]",
"trace.parent_span",
)


def get_columns_from_aliases(aliases):
Expand Down
7 changes: 5 additions & 2 deletions tests/acceptance/test_create_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from sentry.testutils import AcceptanceTestCase
from sentry.models import Project
from mock import patch


class CreateProjectTest(AcceptanceTestCase):
Expand All @@ -13,18 +14,20 @@ def setUp(self):

self.path = u"/organizations/{}/projects/new/".format(self.org.slug)

def test_simple(self):
@patch("django.db.models.signals.ModelSignal.send")
def test_simple(self, mock_signal):
self.team = self.create_team(organization=self.org, name="Mariachi Band")
self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])

self.browser.get(self.path)
self.browser.wait_until_not(".loading")

self.browser.click('[data-test-id="platform-java"]')
self.browser.snapshot(name="create project")

self.browser.click('[data-test-id="create-project"]')
self.browser.wait_until(title="java")
self.browser.wait_until_not(".loading")
self.browser.wait_until("#installation")

project = Project.objects.get(organization=self.org)
assert project.name == "Java"
Expand Down