Skip to content

feat(apm): Navigate from an ancestor transaction to a descendent transaction within a trace #15926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 10, 2019
Merged

feat(apm): Navigate from an ancestor transaction to a descendent transaction within a trace #15926

merged 9 commits into from
Dec 10, 2019

Conversation

@dashed
Copy link
Member

@dashed dashed commented Dec 4, 2019 •
edited
Loading

NOTES

  • A button will either, view the actual descendent transaction span, or view list of descendent transactions in Discover 2

TODO

@dashed dashed added the WIP label Dec 4, 2019
@dashed dashed self-assigned this Dec 4, 2019
@dashed dashed force-pushed the apm-inline-related-transactions branch 2 times, most recently from fbe97d2 to 0ec0e0e Compare December 5, 2019 12:07
@dashed dashed mentioned this pull request Dec 5, 2019
Merged
@dashed dashed force-pushed the apm-inline-related-transactions branch 2 times, most recently from d31d129 to e5a78e7 Compare December 6, 2019 07:23
@dashed dashed changed the title feat(apm): Navigate between transactions within a trace feat(apm): Navigate from an ancestor transaction to a descendent transaction within a trace Dec 6, 2019
@dashed dashed force-pushed the apm-inline-related-transactions branch 2 times, most recently from 970cd07 to ce938ff Compare December 6, 2019 23:08
@dashed dashed mentioned this pull request Dec 7, 2019
Closed
2 tasks
@dashed dashed removed the WIP label Dec 9, 2019
@dashed dashed force-pushed the apm-inline-related-transactions branch from c125293 to d58628e Compare December 9, 2019 21:42
@dashed dashed force-pushed the apm-inline-related-transactions branch from d58628e to 2e2802d Compare December 10, 2019 01:10
markstory
markstory approved these changes Dec 10, 2019
View reviewed changes
src/sentry/static/sentry/app/components/events/interfaces/spans/spanDetail.tsx
if (
!response.data ||
!Array.isArray(response.data) ||
response.data.length <= 0
Copy link
Member

@markstory markstory Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would length be less than 0?

src/sentry/static/sentry/app/components/events/interfaces/spans/spanDetail.tsx
});
}

fetchSpanDescendents(spanID: string): Promise<any> {
Copy link
Member

@markstory markstory Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could move this into an actioncreator module. Having components doing both request/response handing and rendering DOM gets hard to maintain.

Copy link
Member Author

@dashed dashed Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a follow up PR.

@dashed dashed merged commit 8e4d600 into master Dec 10, 2019
@evanpurkhiser evanpurkhiser deleted the apm-inline-related-transactions branch October 13, 2020 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markstory markstory markstory approved these changes

@leedongwei leedongwei Awaiting requested review from leedongwei

@doralchan doralchan Awaiting requested review from doralchan

@wmak wmak Awaiting requested review from wmak

@evanh evanh Awaiting requested review from evanh

Assignees

@dashed dashed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dashed @markstory