Skip to content

test(datasets): Make Sentry use generic test functions in Snuba #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019
Merged

test(datasets): Make Sentry use generic test functions in Snuba #14111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/eventstream/snuba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def _send(self, project_id, _type, extra_data=(), asynchronous=True):

try:
resp = snuba._snuba_pool.urlopen(
'POST', '/tests/eventstream',
'POST', '/tests/events/eventstream',
body=json.dumps(data),
)
if resp.status != 200:
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/testutils/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ def setUp(self):
def init_snuba(self):
self.snuba_eventstream = SnubaEventStream()
self.snuba_tagstore = SnubaCompatibilityTagStorage()
assert requests.post(settings.SENTRY_SNUBA + '/tests/drop').status_code == 200
assert requests.post(settings.SENTRY_SNUBA + '/tests/events/drop').status_code == 200

def store_event(self, *args, **kwargs):
with contextlib.nested(
Expand Down Expand Up @@ -951,7 +951,7 @@ def snuba_insert(self, events):
events = [events]

assert requests.post(
settings.SENTRY_SNUBA + '/tests/insert',
settings.SENTRY_SNUBA + '/tests/events/insert',
data=json.dumps(events)
).status_code == 200

Expand Down
5 changes: 4 additions & 1 deletion tests/snuba/tagstore/test_tagstore_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ def setUp(self):
},
}])

assert requests.post(settings.SENTRY_SNUBA + '/tests/insert', data=data).status_code == 200
assert requests.post(
settings.SENTRY_SNUBA +
'/tests/events/insert',
data=data).status_code == 200

def test_get_group_tag_keys_and_top_values(self):
result = list(self.ts.get_group_tag_keys_and_top_values(
Expand Down
5 changes: 4 additions & 1 deletion tests/snuba/tsdb/test_tsdb_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ def setUp(self):
},
} for r in range(0, 14400, 600)]) # Every 10 min for 4 hours

assert requests.post(settings.SENTRY_SNUBA + '/tests/insert', data=data).status_code == 200
assert requests.post(
settings.SENTRY_SNUBA +
'/tests/events/insert',
data=data).status_code == 200

# snuba trims query windows based on first_seen/last_seen, so these need to be correct-ish
self.proj1group1.first_seen = self.now
Expand Down