Skip to content

fix: Pass an empty array to $.param instead of an empty string when options.query is falsey #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019
Merged

fix: Pass an empty array to $.param instead of an empty string when options.query is falsey #14051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/static/sentry/app/api.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export class Client {
let query;
try {
query = $.param(options.query || '', true);
Copy link
Member

@BYK BYK Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not remove the old line here?

Copy link
Member

@evanpurkhiser evanpurkhiser Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He got it in a separate PR i think

Copy link
Member Author

@dashed dashed Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I got it here #14061

git stash failed me 😢

query = $.param(options.query || [], true);
} catch (err) {
Sentry.withScope(scope => {
scope.setExtra('path', path);
Expand Down