ref(api): Segment web urls #13978
Closed
ref(api): Segment web urls #13978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
commented
Jul 11, 2019
| name='sentry-team-avatar-url' | ||
| ), | ||
|
|
||
| # VSTS Marketplace extension install flow |
Member
Author
There was a problem hiding this comment.
This moved down into the extensions group
markstory
approved these changes
Jul 12, 2019
Member
Author
|
Looks like acceptance tests may not be happy in this change. |
Member
Author
|
Seems like there are some issues here. Will have to look closer. |
Member
Author
|
Will come back to this later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #13941
Mostly just for cleanliness purposes.
I also think we can probably get rid of a lot of the URLs that are just
generic react views, or at least keep them just for route names.