-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
TypeScript configuration #13818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript configuration #13818
Conversation
Hackweek TypeScript prototype
dashed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoot! 🚀
HazAT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
| "@sentry/browser": "^5.4.2", | ||
| "@sentry/integrations": "^5.4.2", | ||
| "@sentry/typescript": "^5.3.0", | ||
| "@types/lodash": "^4.14.134", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be dev deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are needed for the production build right now, but we should probably look into that. @HazAT - I know you mentioned something about this earlier, is that accurate?
The PR contains the commits from #13786 related to supporting TypeScript configuration. Since there are many changes currently underway that change the build process for Sentry's UI, we should merge this first to avoid conflicts later.