Skip to content

Conversation

@lynnagara
Copy link
Member

The PR contains the commits from #13786 related to supporting TypeScript configuration. Since there are many changes currently underway that change the build process for Sentry's UI, we should merge this first to avoid conflicts later.

@lynnagara lynnagara requested review from a team, HazAT and dashed June 25, 2019 21:44
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoot! 🚀

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

"@sentry/browser": "^5.4.2",
"@sentry/integrations": "^5.4.2",
"@sentry/typescript": "^5.3.0",
"@types/lodash": "^4.14.134",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be dev deps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are needed for the production build right now, but we should probably look into that. @HazAT - I know you mentioned something about this earlier, is that accurate?

@lynnagara lynnagara merged commit b443fc1 into master Jun 26, 2019
@lynnagara lynnagara deleted the typescript-support branch June 26, 2019 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants