featu(search) Use snuba to fetch events by default #13700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattrobenolt
left a comment
mattrobenolt
left a comment
There was a problem hiding this comment.
Why not just remove the switch instead? If it’s defaulted to true, there’s 0 reason for someone to turn it off.
mitsuhiko
approved these changes
Jun 15, 2019
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
lgtm but i would indeed remove all the now dead code that hangs on this switch.
Contributor
Author
|
I cannot remove the switch yet because there is a handful of tests that force it to False. I will address them in a separate PR. |
fpacifici
force-pushed
the
feat/enable_snuba_query
branch
2 times, most recently
from
24acdb4 to
5d6fb4d
Compare
markstory
approved these changes
Jun 19, 2019
| min_ago = (timezone.now() - timedelta(minutes=1)).isoformat()[:19] | ||
| self.event = self.store_event( | ||
| data={ | ||
| # 'event_id': 'a' * 32, |
| # 'event_id': 'a' * 32, | ||
| 'fingerprint': ['group1'], | ||
| 'timestamp': min_ago, | ||
| # 'tags': {'sentry:release': release.version}, |
Member
There was a problem hiding this comment.
More commented code that could be removed.
Contributor
Author
There was a problem hiding this comment.
weird, I thought I removed all of them. Will fix
snuba.events-queries.enabled option is already active in production. This commit activates it by default and fixes the tests that did not support it. This step is needed in order to remove our dependency on PG events which is useful for issueless events.
fpacifici
force-pushed
the
feat/enable_snuba_query
branch
from
0643a49 to
cbabee5
Compare
fpacifici
added a commit
that referenced
this pull request
Jun 20, 2019
#13700 changed the way test events are generated. The result is that, in acceptance tests, the time the event is created is not normalized to the day thus the screenshot of the details page is different at every execution breaking the snapshot tests on percy. This normalizes the creation timestamp thus should make the snapshot consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snuba.events-queries.enabled option is supposed to be already active in production. This commit activates it by default and fixes the tests that did not support it.
This step is needed in order to remove our dependency on PG events which is useful for issueless
events.