Skip to content

fix: Update span ops #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022
Merged

fix: Update span ops #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8a47a
fix: Update span ops
cleptric Sep 23, 2022
6971e20
Merge branch 'master' into mh/span-ops
cleptric Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tracing/Doctrine/DBAL/AbstractTracingStatement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ abstract class AbstractTracingStatement
/**
* @internal
*/
public const SPAN_OP_STMT_EXECUTE = 'sql.stmt.execute';
public const SPAN_OP_STMT_EXECUTE = 'db.sql.execute';

/**
* @var HubInterface The current hub
Expand Down
12 changes: 6 additions & 6 deletions src/Tracing/Doctrine/DBAL/TracingDriverConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,32 +23,32 @@ final class TracingDriverConnection implements TracingDriverConnectionInterface
/**
* @internal
*/
public const SPAN_OP_CONN_PREPARE = 'sql.conn.prepare';
public const SPAN_OP_CONN_PREPARE = 'db.sql.prepare';

/**
* @internal
*/
public const SPAN_OP_CONN_QUERY = 'sql.conn.query';
public const SPAN_OP_CONN_QUERY = 'db.sql.query';

/**
* @internal
*/
public const SPAN_OP_CONN_EXEC = 'sql.conn.exec';
public const SPAN_OP_CONN_EXEC = 'db.sql.exec';

/**
* @internal
*/
public const SPAN_OP_CONN_BEGIN_TRANSACTION = 'sql.conn.begin_transaction';
public const SPAN_OP_CONN_BEGIN_TRANSACTION = 'db.sql.transaction.begin';

/**
* @internal
*/
public const SPAN_OP_TRANSACTION_COMMIT = 'sql.transaction.commit';
public const SPAN_OP_TRANSACTION_COMMIT = 'db.sql.transaction.commit';

/**
* @internal
*/
public const SPAN_OP_TRANSACTION_ROLLBACK = 'sql.transaction.rollback';
public const SPAN_OP_TRANSACTION_ROLLBACK = 'db.sql.transaction.rollback';

/**
* @var HubInterface The current hub
Expand Down