Issue with custom error template rendering with 500 error

[adrienfr]

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Steps to Reproduce

1. Migrate from "sentry/sentry-symfony:4.0" to "sentry/sentry-symfony:4.1"
2. Env is prod (and debug is false)
3. Monolog enabled
4. Generate a 500 error

Expected Result

This should display my custom error page (templates/bundles/TwigBundle/Exception/error.html.twig)

Actual Result

The displayed error is the generic one :

It seems that TwigErrorRenderer is not called anymore.

404 errors are not concerned, the custom error page (templates/bundles/TwigBundle/Exception/error404.html.twig) is correctly displayed (as it was before on "sentry/sentry-symfony:4.0").

Here is my configuration :

prod/sentry.yml

sentry:
    dsn: "%sentry.dsn%"
    options:
        environment: "%kernel.environment%"
        send_default_pii: true

[ste93cry]

Can you please try setting sentry.tracing.twig.enabled to false?

[adrienfr]

This doesn't change anything but it does when setting sentry.tracing.enabled to false or :

    tracing:
        twig:
            enabled: true
        cache:
            enabled: true
        dbal:
            enabled: false

The issue seems to be with dbal tracing instead with configureConnectionForDoctrineDBALVersion2

[ste93cry]

Can you please came up with a really small repo reproducing the issue? I have little to no information here to understand what's the issue

[adrienfr]

Can you please came up with a really small repo reproducing the issue? I have little to no information here to understand what's the issue

I'll try to create a reproducer.

Could it be a consequence of doctrine.dbal.logging not enabled ? (see #426 (comment)) ?

[ste93cry]

Could it be a consequence of doctrine.dbal.logging not enabled ?

I don't think so because we completely changed the way we hook into Doctrine for tracing in respect to that initial comment. However, our method is for sure more invasive because we wrap the driver connection, so if something is happening inside there then understanding the cause without a reproducer may be complicated

[Jean85]

Can you try to enable Sentry AND the tracing locally, to see if you get any information about your issue?

In either case, do you get any event reported to Sentry, containing any relevant information?

@ste93cry we need to keep in mind #484 as a possible cause.

[adrienfr]

The event is successfully reported on Sentry, as below:

ErrorException: Notice: Trying to get property 'headers' of non-object
#4 /src/Controller/FlatController.php(181): App\Controller\FlatController::createAction
#3 /vendor/symfony/http-kernel/HttpKernel.php(157): Symfony\Component\HttpKernel\HttpKernel::handleRaw
#2 /vendor/symfony/http-kernel/HttpKernel.php(79): Symfony\Component\HttpKernel\HttpKernel::handle
#1 /vendor/symfony/http-kernel/Kernel.php(196): Symfony\Component\HttpKernel\Kernel::handle
#0 /public/index.php(31): null

And when enabling debug (APP_DEBUG=true), here is the layout:

Hope I can generate a reproducer in the evening to help you.

[adrienfr]

It works when I comment in TracingDriverConnection->traceFunction() (see https://github.com/getsentry/sentry-symfony/blob/master/src/Tracing/Doctrine/DBAL/TracingDriverConnection.php#L212) :

// return $callback();

I will provide a reproducer tomorrow.

[adrienfr]

I think I found a possible cause, the issue occurs with package fresh/doctrine-enum-bundle (link)

[adrienfr]

Here is a simple reproducer, can you tell me if you need anything else? https://github.com/adrienfr/debug-sentry

[Jean85]

I have issues with your reproducer: it required me to install PDO SQLite (done) but I still get the generic 500 instead of the 404.

[ste93cry]

I was able to run the reproducer and I indeed can see the issue, although the funny thing is that it appears after reloading the page a second time: with a cache still to be created the error page renders fine 🤔 The good news is that, as you pointed out, the issue seems to be with the DBAL, even though I don't know why, and this is already a starting point. I'm investigating the problem and I will write back once I find the root cause