Skip to content

Conversation

lcian
Copy link
Member

@lcian lcian commented Sep 19, 2025

Description

In #858 we added reporting for trace origin.
The implementation there was actually incorrect because we attached origin to the trace data.
Instead, we need to add a new field on TraceContext called origin, and write it there.
Technically this is a breaking change, but I imagine it's very unlikely that a user needs to construct this struct.

Issues

Closes #907
Closes RUST-110

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.46%. Comparing base (75a8c03) to head (064c8ce).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   73.44%   73.46%   +0.01%     
==========================================
  Files          64       64              
  Lines        7502     7506       +4     
==========================================
+ Hits         5510     5514       +4     
  Misses       1992     1992              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

linear bot commented Sep 22, 2025

@lcian lcian marked this pull request as ready for review September 22, 2025 11:28
@lcian lcian merged commit 6b61b31 into master Sep 22, 2025
20 checks passed
@lcian lcian deleted the lcian/proper-trace-origin branch September 22, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace origin is sent incorrectly
2 participants