Skip to content

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Sep 17, 2025

So that rust-analyzer also analyzes feature-flag-guarded portions of code when using VSCode/Cursor.

#skip-changelog

So that `rust-analyzer` also analyzes any `logs` feature-flag-guarded portions of code when using VSCode/Cursor.
Copy link
Member Author

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to close if you don't want this – I noticed the potential improvement while reviewing #899

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.46%. Comparing base (750dec0) to head (578f3cd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files          64       64           
  Lines        7518     7518           
=======================================
  Hits         5523     5523           
  Misses       1995     1995           

@lcian
Copy link
Member

lcian commented Sep 17, 2025

Nice thanks @szokeasaurusrex, should we enable all features directly? Any downside of doing so?
https://users.rust-lang.org/t/how-to-turn-on-all-or-specified-features-of-a-crate-during-development/93672/2

@lcian
Copy link
Member

lcian commented Sep 17, 2025

In fact, I do enable the features I need locally for development directly in Cargo.toml (because I use neovim, I will try if it's compatible with this editorconfig config, but I suspect this one wouldn't work)
Sorry this is not even editorconfig this is vscode so it won't work for me for sure.
But it can be helpful for people that use vscode

@szokeasaurusrex
Copy link
Member Author

@lcian we could also enable all features. I am not aware of any downsides of doing so

@lcian
Copy link
Member

lcian commented Sep 17, 2025

I guess rust-analyzer will be a bit slower, but I think it makes sense to enable all features

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) September 30, 2025 13:14
@szokeasaurusrex szokeasaurusrex changed the title meta(vscode): Add logs to rust-analyzer features meta(vscode): Run rust-analyzer with all features Sep 30, 2025
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) September 30, 2025 13:15
@szokeasaurusrex szokeasaurusrex merged commit 9ba9a64 into master Sep 30, 2025
32 of 33 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/rust-analyzer-features branch September 30, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants