Skip to content

Conversation

algesten
Copy link
Contributor

@algesten algesten commented Jun 6, 2025

Update from ureq 2.x to 3.x. In ureq 3.x, rustls API is in itself not
exposed. That simplifies some of the TLS config. Furthermore the
webpki-roots are bundled and updated using patch-versions.

Close #834

Update from ureq 2.x to 3.x. In ureq 3.x, rustls API is in itself not
exposed. That simplifies some of the TLS config. Furthermore the
webpki-roots are bundled and updated using patch-versions.
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, the code looks a lot simpler and there is less manual steps involved 🎉

IMO this should be good to go, but a cargo update can’t hurt.

]

[[package]]
name = "webpki-root-certs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, what is the difference to webpki-roots? or is this complementary?

Maybe its a good idea to run a cargo update as well, to harmonize the versions, and give cargo an opportunity to maybe remove some duplicates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpki-roots is optimized for rustls, while webpki-root-certs is more generic so it can be used with other TLS backends.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 73.36%. Comparing base (c92d8d8) to head (50c7c6e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   72.85%   73.36%   +0.51%     
==========================================
  Files          64       64              
  Lines        7732     7678      -54     
==========================================
  Hits         5633     5633              
+ Misses       2099     2045      -54     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Swatinem
Copy link
Member

Looks like base64ct has already updated to rust 2024. Maybe you can use the MSRV-aware solver to make sure we downgrade to a compatible version?

@algesten
Copy link
Contributor Author

Looks like base64ct has already updated to rust 2024. Maybe you can use the MSRV-aware solver to make sure we downgrade to a compatible version?

I'll have a look!

@lcian
Copy link
Member

lcian commented Jun 11, 2025

Thank you @algesten !
I've merged master and added a changelog entry.
Anything else you want to change or can we go ahead and merge this?

@algesten
Copy link
Contributor Author

Looks good to me!

@lcian lcian merged commit 2b1455b into getsentry:master Jun 11, 2025
16 checks passed
loewenheim added a commit to getsentry/reqwest that referenced this pull request Jul 7, 2025
Bump rustls-pki-types to v1.11.0.
This is needed to upgrade sentry-rust in Symbolicator due to the recent upgrade of ureq to v3 in sentry-rust: getsentry/sentry-rust#835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to ureq 3.x
3 participants