-
-
Notifications
You must be signed in to change notification settings - Fork 167
Update ureq to 3.x (#834) #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update from ureq 2.x to 3.x. In ureq 3.x, rustls API is in itself not exposed. That simplifies some of the TLS config. Furthermore the webpki-roots are bundled and updated using patch-versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, the code looks a lot simpler and there is less manual steps involved 🎉
IMO this should be good to go, but a cargo update
can’t hurt.
] | ||
|
||
[[package]] | ||
name = "webpki-root-certs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, what is the difference to webpki-roots
? or is this complementary?
Maybe its a good idea to run a cargo update
as well, to harmonize the versions, and give cargo an opportunity to maybe remove some duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webpki-roots
is optimized for rustls, while webpki-root-certs
is more generic so it can be used with other TLS backends.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 72.85% 73.36% +0.51%
==========================================
Files 64 64
Lines 7732 7678 -54
==========================================
Hits 5633 5633
+ Misses 2099 2045 -54 🚀 New features to boost your workflow:
|
Looks like |
I'll have a look! |
Thank you @algesten ! |
Looks good to me! |
Bump rustls-pki-types to v1.11.0. This is needed to upgrade sentry-rust in Symbolicator due to the recent upgrade of ureq to v3 in sentry-rust: getsentry/sentry-rust#835
Update from ureq 2.x to 3.x. In ureq 3.x, rustls API is in itself not
exposed. That simplifies some of the TLS config. Furthermore the
webpki-roots are bundled and updated using patch-versions.
Close #834