fix(tracing): Time To Initial Display / Time To Full Display: remove warning that it's unsupported #5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98f632c | 424.25 ms | 435.48 ms | 11.23 ms |
| 3e0a5f9 | 401.72 ms | 394.98 ms | -6.74 ms |
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| e2fa43d | 451.68 ms | 462.42 ms | 10.74 ms |
| 64cd15c | 439.02 ms | 427.63 ms | -11.39 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 785ffb1 | 471.92 ms | 460.96 ms | -10.96 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 534ba8c | 484.00 ms | 499.93 ms | 15.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98f632c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 3e0a5f9 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| e2fa43d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 64cd15c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 785ffb1 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 534ba8c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
alwx
changed the title
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 534ba8c+dirty | 472.35 ms | 537.31 ms | 64.96 ms |
| eb07ba3+dirty | 419.49 ms | 482.12 ms | 62.63 ms |
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| 3e0a5f9+dirty | 379.92 ms | 450.96 ms | 71.04 ms |
| 98f632c+dirty | 323.98 ms | 375.39 ms | 51.41 ms |
| 64cd15c+dirty | 488.79 ms | 483.54 ms | -5.24 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
| 7be1f99+dirty | 369.02 ms | 399.60 ms | 30.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 534ba8c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| eb07ba3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3e0a5f9+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 98f632c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 64cd15c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 7be1f99+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| e2fa43d+dirty | 1216.04 ms | 1232.65 ms | 16.61 ms |
| 785ffb1+dirty | 1237.63 ms | 1240.50 ms | 2.87 ms |
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| 98f632c+dirty | 1236.40 ms | 1241.62 ms | 5.22 ms |
| 534ba8c+dirty | 1230.22 ms | 1231.18 ms | 0.96 ms |
| 64cd15c+dirty | 1216.31 ms | 1214.04 ms | -2.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| e2fa43d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 785ffb1+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 98f632c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 534ba8c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 64cd15c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
| e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
| 785ffb1+dirty | 1213.71 ms | 1213.37 ms | -0.35 ms |
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| 98f632c+dirty | 1221.38 ms | 1229.26 ms | 7.88 ms |
| 534ba8c+dirty | 1225.00 ms | 1237.43 ms | 12.43 ms |
| 64cd15c+dirty | 1213.50 ms | 1223.54 ms | 10.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 785ffb1+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 98f632c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 534ba8c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 64cd15c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
…implemented via Fabric components
alwx
force-pushed
the
alwx/improvement/ttid-ttfd
branch
from
44835d8 to
dcf217c
Compare
alwx
changed the title
antonis
reviewed
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Partially fixes #4705
📜 Description
The solution for now is the following: we can now remove the checks in the SDK and basically make it work with the new architecture. However, we will need to implement TTID/TTFD as turbo modules to make it more efficient: #4705
Here is the corresponding docs change: getsentry/sentry-docs#14662
💡 Motivation and Context
This change is needed to not show message that it's not supported because it actually is supported :)
💚 How did you test it?
With the sample app:
(not all the results are there because I did experiment with <Sentry.TimeToInitialDisplay /> and <Sentry.TimeToFullDisplay /> wrapper components on individual screens)
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps