Skip to content

chore(ci): Handle GH runner image deprecations #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2025
Merged

chore(ci): Handle GH runner image deprecations #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b38cd2
chore(ci): Bump iOS simulator to 18.6
antonis Aug 14, 2025
e0b4f9d
Revert "chore(ci): Bump iOS simulator to 18.6"
antonis Aug 14, 2025
f256dd7
Test macos-14 image
antonis Aug 14, 2025
54ad6da
Test macos-14 image
antonis Aug 14, 2025
08d9cf7
Select xcode version
antonis Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
- platform: ios
rn-version: '0.80.2'
xcode-version: '16.2'
runs-on: macos-15
runs-on: macos-14
- platform: ios
rn-version: '0.65.3'
xcode-version: '14.2'
Expand Down Expand Up @@ -310,7 +310,7 @@ jobs:
include:
- platform: ios
rn-version: '0.80.2'
runs-on: macos-15
runs-on: macos-14
- platform: ios
rn-version: '0.65.3'
runs-on: macos-15
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/sample-application-expo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ jobs:
build-type: ['dev', 'production']
include:
- platform: ios
runs-on: macos-15
xcode-version: '16.2'
runs-on: macos-14
- platform: android
runs-on: ubuntu-latest
- platform: web
Expand Down Expand Up @@ -70,6 +71,9 @@ jobs:
- name: Gradle cache
uses: gradle/gradle-build-action@ac2d340dc04d9e1113182899e983b5400c17cda1 # v3.5.0

- run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode-version }}.app/Contents/Developer
if: ${{ matrix.platform == 'ios' }}

- name: Setup Global Xcode Tools
if: ${{ matrix.platform == 'ios' }}
run: which xcbeautify || brew install xcbeautify
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sample-application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
build-type: ['dev', 'production']
include:
- platform: ios
runs-on: macos-15
runs-on: macos-14
- platform: macos
Comment on lines +46 to 47
Copy link

@seer-by-sentry seer-by-sentry bot Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The `sample-application.yml` workflow relies on the default Xcode version of the `macos-14` runner, which could cause non-deterministic build failures if the default changes or lacks required iOS simulators.

  • Description: The sample-application.yml workflow is updated to use runs-on: macos-14 but, unlike other workflows in this change, it does not explicitly configure an Xcode version. The workflow hardcodes IOS_DEVICE: 'iPhone 16' and IOS_VERSION: '18.1', which require a specific Xcode version. Relying on the runner's default Xcode version creates a risk of non-deterministic build failures if the default does not support these specific iOS simulator requirements. This inconsistency could block development workflows if the environment expectations are not met.

  • Suggested fix: To ensure build stability and consistency, add an explicit Xcode version to the sample-application.yml workflow matrix, similar to the sample-application-expo.yml workflow. This involves adding xcode-version: '16.2' to the matrix and including a step to select it using sudo xcode-select.
    severity: 0.65, confidence: 0.9

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor Author

@antonis antonis Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this to be tackled properly in #5082

runs-on: macos-15
- platform: android
Expand Down Expand Up @@ -218,7 +218,7 @@ jobs:
matrix:
include:
- platform: ios
runs-on: macos-15
runs-on: macos-14
rn-architecture: 'new'
ios-use-frameworks: 'no-frameworks'
build-type: 'production'
Expand Down
Loading