Support New Hermes Runtime Access Pattern #5051
Merged
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@lucas-zimerman I fixed the lint issue and added the changelog |
|
Thank you for your incredible fixes!!! I have approved CI to run, but I will only be able to fully review the PR tomorrow morning. |
|
Thanks a lot @lucas-zimerman ❤️ no worries I don't think it is urgent since RN 81 is still in RC, not gonna be released tmw 😂 |
antonis
reviewed
Aug 8, 2025
antonis
reviewed
Aug 8, 2025
antonis
reviewed
Aug 8, 2025
lucas-zimerman
approved these changes
Aug 8, 2025
nathan-ahn
pushed a commit
to nathan-ahn/sentry-react-native
that referenced
this pull request
Sep 14, 2025
* Update sentry_utils.rb * Update RNSentry.mm * Update RNSentry.podspec * lint clang and add changelog * PR review comments * Update CHANGELOG.md --------- Co-authored-by: Antonis Lilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
In React Native 81 Hermes changes their runtime access pattern.
💡 Motivation and Context
In React Native 81 Hermes changes their runtime access pattern.
so this checks if new hermes runtime is available it uses it, otherwise it uses old code.
💚 How did you test it?
I installed Sentry on React Native 81 project and did a build, it didn't work.
I applied this patch then it worked.
I also tried the patch with react native 80 and 79, and all went well.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps