Logs: Capture more device attributes #5032

lucas-zimerman · 2025-07-30T17:58:44Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

This PR adds the following attributes to JavaScript Logs:

Device brand.
Device model
Device family
OS Name
OS Version
Release

💡 Motivation and Context

Native logs contains those informations so it's strange to have some logs having this information while others don't.

💚 How did you test it?

Tests, CI, on Android/iOS device

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Close: #4935

…context info

github-actions · 2025-07-30T18:36:09Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.82 ms	1223.50 ms	2.68 ms
Size	3.19 MiB	4.39 MiB	1.20 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`3c99746`+dirty	1227.65 ms	1228.81 ms	1.16 ms
`f870f2d`+dirty	1230.08 ms	1238.88 ms	8.80 ms
`0e27665`+dirty	1207.12 ms	1220.33 ms	13.20 ms
`fb47c4a`+dirty	1243.40 ms	1245.86 ms	2.46 ms
`7eff2d7`+dirty	1224.84 ms	1227.94 ms	3.10 ms
`472960b`+dirty	1243.67 ms	1233.57 ms	-10.11 ms
`c26618b`+dirty	1228.54 ms	1236.52 ms	7.98 ms
`10ec2e1`+dirty	1229.04 ms	1222.28 ms	-6.76 ms
`11cc947`+dirty	1218.92 ms	1234.24 ms	15.33 ms
`20d0171`+dirty	1214.21 ms	1220.31 ms	6.10 ms

App size

Revision	Plain	With Sentry	Diff
`3c99746`+dirty	3.19 MiB	4.35 MiB	1.16 MiB
`f870f2d`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`0e27665`+dirty	3.19 MiB	4.37 MiB	1.18 MiB
`fb47c4a`+dirty	3.19 MiB	4.37 MiB	1.18 MiB
`7eff2d7`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`472960b`+dirty	3.19 MiB	4.36 MiB	1.17 MiB
`c26618b`+dirty	3.19 MiB	4.39 MiB	1.20 MiB
`10ec2e1`+dirty	3.19 MiB	4.39 MiB	1.20 MiB
`11cc947`+dirty	3.19 MiB	4.39 MiB	1.20 MiB
`20d0171`+dirty	3.19 MiB	4.37 MiB	1.18 MiB

github-actions · 2025-07-30T18:37:28Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1244.00 ms	1252.04 ms	8.04 ms
Size	2.63 MiB	3.83 MiB	1.19 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`3c99746`+dirty	1215.12 ms	1222.31 ms	7.18 ms
`f870f2d`+dirty	1227.18 ms	1232.30 ms	5.12 ms
`0e27665`+dirty	1213.52 ms	1237.61 ms	24.09 ms
`fb47c4a`+dirty	1231.00 ms	1231.33 ms	0.33 ms
`7eff2d7`+dirty	1225.34 ms	1234.53 ms	9.19 ms
`472960b`+dirty	1213.96 ms	1222.58 ms	8.62 ms
`c26618b`+dirty	1230.06 ms	1233.30 ms	3.24 ms
`10ec2e1`+dirty	1228.02 ms	1237.54 ms	9.52 ms
`11cc947`+dirty	1239.65 ms	1239.64 ms	-0.01 ms
`20d0171`+dirty	1214.96 ms	1215.20 ms	0.25 ms

App size

Revision	Plain	With Sentry	Diff
`3c99746`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`f870f2d`+dirty	2.63 MiB	3.79 MiB	1.15 MiB
`0e27665`+dirty	2.63 MiB	3.80 MiB	1.17 MiB
`fb47c4a`+dirty	2.63 MiB	3.80 MiB	1.17 MiB
`7eff2d7`+dirty	2.63 MiB	3.79 MiB	1.16 MiB
`472960b`+dirty	2.63 MiB	3.79 MiB	1.15 MiB
`c26618b`+dirty	2.63 MiB	3.82 MiB	1.19 MiB
`10ec2e1`+dirty	2.63 MiB	3.82 MiB	1.19 MiB
`11cc947`+dirty	2.63 MiB	3.82 MiB	1.19 MiB
`20d0171`+dirty	2.63 MiB	3.80 MiB	1.17 MiB

…ntry-react-native into lz/v7/logs-enricher

github-actions · 2025-08-04T22:00:42Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	440.32 ms	427.86 ms	-12.46 ms
Size	17.75 MiB	19.60 MiB	1.86 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`472960b`	418.84 ms	405.38 ms	-13.46 ms
`c26618b`	435.76 ms	430.14 ms	-5.62 ms
`0e27665`	356.27 ms	367.74 ms	11.47 ms
`10ec2e1`	435.28 ms	431.58 ms	-3.70 ms
`7eff2d7`	420.64 ms	401.86 ms	-18.78 ms
`f870f2d`	444.67 ms	449.62 ms	4.95 ms
`11cc947`	501.96 ms	486.04 ms	-15.92 ms
`fb47c4a`	435.33 ms	434.94 ms	-0.40 ms
`3c99746`	399.51 ms	429.09 ms	29.58 ms
`20d0171`	366.62 ms	366.43 ms	-0.19 ms

App size

Revision	Plain	With Sentry	Diff
`472960b`	17.75 MiB	19.58 MiB	1.83 MiB
`c26618b`	17.75 MiB	19.60 MiB	1.85 MiB
`0e27665`	17.75 MiB	19.60 MiB	1.85 MiB
`10ec2e1`	17.75 MiB	19.60 MiB	1.85 MiB
`7eff2d7`	17.75 MiB	19.60 MiB	1.85 MiB
`f870f2d`	17.75 MiB	19.58 MiB	1.83 MiB
`11cc947`	17.75 MiB	19.60 MiB	1.86 MiB
`fb47c4a`	17.75 MiB	19.60 MiB	1.85 MiB
`3c99746`	17.75 MiB	19.58 MiB	1.83 MiB
`20d0171`	17.75 MiB	19.60 MiB	1.85 MiB

github-actions · 2025-08-04T22:19:06Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	427.10 ms	469.00 ms	41.90 ms
Size	7.15 MiB	8.36 MiB	1.21 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`10ec2e1`+dirty	373.87 ms	443.64 ms	69.78 ms
`c26618b`+dirty	354.44 ms	414.73 ms	60.29 ms
`3c99746`+dirty	400.65 ms	399.59 ms	-1.06 ms
`472960b`+dirty	394.39 ms	376.18 ms	-18.20 ms
`f870f2d`+dirty	398.49 ms	434.24 ms	35.75 ms
`11cc947`+dirty	385.96 ms	420.08 ms	34.12 ms
`fb47c4a`+dirty	408.58 ms	407.17 ms	-1.41 ms
`0e27665`+dirty	355.91 ms	422.52 ms	66.61 ms
`20d0171`+dirty	380.17 ms	422.57 ms	42.40 ms
`7eff2d7`+dirty	393.13 ms	426.77 ms	33.65 ms

App size

Revision	Plain	With Sentry	Diff
`10ec2e1`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`c26618b`+dirty	7.15 MiB	8.36 MiB	1.20 MiB
`3c99746`+dirty	7.15 MiB	8.34 MiB	1.18 MiB
`472960b`+dirty	7.15 MiB	8.34 MiB	1.18 MiB
`f870f2d`+dirty	7.15 MiB	8.34 MiB	1.18 MiB
`11cc947`+dirty	7.15 MiB	8.36 MiB	1.20 MiB
`fb47c4a`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`0e27665`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`20d0171`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`7eff2d7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB

antonis

The code LGTM and worked as expected with the sample app 🚀

add javascript logic (WIP when to spawn cache) / implemented Android …

6e6ea74

…context info

lucas-zimerman added 8 commits July 31, 2025 17:35

fix logic and also implement ios side

95b280a

remove setTimeout and use afterInit hook, add tests

d0bd30c

yarn fix

44efeb1

use java 8 syntax

ea2def5

changelog

7eed3c2

Merge branch 'v7' into lz/v7/logs-enricher

4d399ce

clang fix?

cc6171c

Merge branch 'lz/v7/logs-enricher' of https://github.com/getsentry/se…

a48afee

…ntry-react-native into lz/v7/logs-enricher

lucas-zimerman marked this pull request as ready for review August 4, 2025 22:10

lucas-zimerman requested a review from antonis as a code owner August 4, 2025 22:10

antonis approved these changes Aug 5, 2025

View reviewed changes

antonis merged commit 63313a6 into v7 Aug 5, 2025
92 of 93 checks passed

antonis deleted the lz/v7/logs-enricher branch August 5, 2025 12:08

lucas-zimerman mentioned this pull request Aug 5, 2025

(LOGS-V7): Link to Native log processors #4935

Closed

Uh oh!

Logs: Capture more device attributes #5032

Logs: Capture more device attributes #5032

Uh oh!

Conversation

lucas-zimerman commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Uh oh!

github-actions bot commented Aug 4, 2025

Android (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Uh oh!

github-actions bot commented Aug 4, 2025

Android (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucas-zimerman commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading