ref: Use SentryOptionsInternal #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12044e | 453.78 ms | 437.58 ms | -16.20 ms |
| ec2a485 | 450.84 ms | 447.49 ms | -3.35 ms |
| 38a1af2 | 404.02 ms | 419.89 ms | 15.86 ms |
| ff0e5d8 | 403.23 ms | 406.54 ms | 3.31 ms |
| 940bd65 | 466.31 ms | 458.52 ms | -7.79 ms |
| 9e3030a | 421.47 ms | 418.65 ms | -2.82 ms |
| d079998 | 460.60 ms | 459.56 ms | -1.05 ms |
| a3aad2b | 453.57 ms | 463.62 ms | 10.05 ms |
| 368003b | 441.36 ms | 435.04 ms | -6.32 ms |
| f25ae46 | 459.92 ms | 451.78 ms | -8.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e12044e | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ec2a485 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 38a1af2 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ff0e5d8 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 940bd65 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 9e3030a | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| d079998 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| a3aad2b | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 368003b | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| f25ae46 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7e38386+dirty | 384.57 ms | 450.06 ms | 65.49 ms |
| f25ae46+dirty | 366.14 ms | 367.96 ms | 1.82 ms |
| 1633d3b+dirty | 385.78 ms | 452.61 ms | 66.83 ms |
| 9e3030a+dirty | 390.15 ms | 381.82 ms | -8.33 ms |
| d18ddb1+dirty | 339.92 ms | 376.15 ms | 36.23 ms |
| 6715c24+dirty | 378.57 ms | 417.54 ms | 38.97 ms |
| f0b931f+dirty | 340.44 ms | 412.62 ms | 72.18 ms |
| 4e2cbd2+dirty | 371.98 ms | 392.00 ms | 20.02 ms |
| 9167f73+dirty | 372.49 ms | 389.90 ms | 17.41 ms |
| ffab994+dirty | 396.46 ms | 440.75 ms | 44.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7e38386+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| f25ae46+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 1633d3b+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 9e3030a+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| d18ddb1+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 6715c24+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| f0b931f+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 4e2cbd2+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 9167f73+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| ffab994+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
noahsmartin
force-pushed
the
useOptionsInternal
branch
4 times, most recently
from
6eeaf4a to
19b7c65
Compare
noahsmartin
force-pushed
the
useOptionsInternal
branch
from
19b7c65 to
c55c4c9
Compare
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab18954+dirty | 1230.53 ms | 1227.26 ms | -3.27 ms |
| 26286ef+dirty | 1213.45 ms | 1229.96 ms | 16.51 ms |
| b13b9dd+dirty | 1232.02 ms | 1236.25 ms | 4.23 ms |
| c352c30+dirty | 1216.60 ms | 1231.37 ms | 14.77 ms |
| 69721ae+dirty | 1229.82 ms | 1226.00 ms | -3.82 ms |
| 6e8a851+dirty | 1227.96 ms | 1235.61 ms | 7.65 ms |
| f76175c+dirty | 1223.29 ms | 1232.52 ms | 9.23 ms |
| 7e38386+dirty | 1214.42 ms | 1214.75 ms | 0.33 ms |
| c5c2e71+dirty | 1231.91 ms | 1235.06 ms | 3.15 ms |
| ff0e5d8+dirty | 1207.33 ms | 1215.83 ms | 8.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab18954+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| 26286ef+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| b13b9dd+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c352c30+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 69721ae+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| 6e8a851+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| f76175c+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| 7e38386+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c5c2e71+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ff0e5d8+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab18954+dirty | 1225.65 ms | 1226.09 ms | 0.44 ms |
| 7d3c3cb+dirty | 1214.56 ms | 1234.53 ms | 19.97 ms |
| 26286ef+dirty | 1207.33 ms | 1202.27 ms | -5.06 ms |
| b13b9dd+dirty | 1210.17 ms | 1227.11 ms | 16.93 ms |
| 69721ae+dirty | 1251.53 ms | 1253.69 ms | 2.16 ms |
| 6e8a851+dirty | 1222.57 ms | 1223.67 ms | 1.10 ms |
| f76175c+dirty | 1228.08 ms | 1234.00 ms | 5.92 ms |
| 7e38386+dirty | 1192.26 ms | 1213.08 ms | 20.82 ms |
| c5c2e71+dirty | 1233.45 ms | 1231.24 ms | -2.20 ms |
| ff0e5d8+dirty | 1228.98 ms | 1234.43 ms | 5.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ab18954+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 7d3c3cb+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 26286ef+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| b13b9dd+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 69721ae+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 6e8a851+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| f76175c+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 7e38386+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c5c2e71+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ff0e5d8+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In getsentry/sentry-cocoa#5698 I renamed this initializer to be a static method on
SentryOptionsInternalso that it's not tied to the implementation ofSentryOptions. I gated this fix behind the import availability and a compiler flag in the tests. This way we can still compile the tests over in the sentry-cocoa repo. Once we release the next sentry-cocoa version we can update RN to use it and remove this flag#skip-changelog.