Fix for sentry-cli path discovery not working on Android
#5009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes
sentry-clipath discovery not working on Android.💡 Motivation and Context
resolveSentryCliPackagePathwas always ending up in the fallback path. This didn't work for me since I'm using a monorepo and sentry-cli isn't in the fallback location.The previous code was trying to pass a
Processtonew File()(instead of a String) and there's no File constructor that takes a Process so it'd immediately end up in the catch block💚 How did you test it?
Locally edited
node_modules/@sentry/react-native/sentry.gradlewhen I found the upload task was failing after I updated from 5.35.0 to 6.18.0.📝 Checklist
sendDefaultPIIis enabled🔮 Next steps