Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 9, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Expose featureFlagsIntegration and FeatureFlagsIntegration type

JS Docs: https://docs.sentry.io/platforms/javascript/configuration/integrations/featureflags/

💡 Motivation and Context

Fixes #4983

💚 How did you test it?

Manual with the sample app (example event)

Screenshot 2025-07-09 at 1 45 44 PM

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e1e696f

@antonis antonis changed the title feat(feature-flags): Expose featureFlagsIntegration feat(feature-flags): v7: Expose featureFlagsIntegration Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.16 ms 413.17 ms -13.00 ms
Size 17.75 MiB 19.60 MiB 1.85 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
3c99746 399.51 ms 429.09 ms 29.58 ms
f870f2d 444.67 ms 449.62 ms 4.95 ms
fb47c4a 435.33 ms 434.94 ms -0.40 ms
7eff2d7 420.64 ms 401.86 ms -18.78 ms
472960b 418.84 ms 405.38 ms -13.46 ms

App size

Revision Plain With Sentry Diff
3c99746 17.75 MiB 19.58 MiB 1.83 MiB
f870f2d 17.75 MiB 19.58 MiB 1.83 MiB
fb47c4a 17.75 MiB 19.60 MiB 1.85 MiB
7eff2d7 17.75 MiB 19.60 MiB 1.85 MiB
472960b 17.75 MiB 19.58 MiB 1.83 MiB

Previous results on branch: antonis/expose-featureFlagsIntegration

Startup times

Revision Plain With Sentry Diff
5d0c968 428.02 ms 417.64 ms -10.38 ms

App size

Revision Plain With Sentry Diff
5d0c968 17.75 MiB 19.60 MiB 1.85 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.63 ms 483.54 ms 50.91 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
f870f2d+dirty 398.49 ms 434.24 ms 35.75 ms
fb47c4a+dirty 408.58 ms 407.17 ms -1.41 ms
3c99746+dirty 400.65 ms 399.59 ms -1.06 ms
7eff2d7+dirty 393.13 ms 426.77 ms 33.65 ms
472960b+dirty 394.39 ms 376.18 ms -18.20 ms

App size

Revision Plain With Sentry Diff
f870f2d+dirty 7.15 MiB 8.34 MiB 1.18 MiB
fb47c4a+dirty 7.15 MiB 8.35 MiB 1.20 MiB
3c99746+dirty 7.15 MiB 8.34 MiB 1.18 MiB
7eff2d7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
472960b+dirty 7.15 MiB 8.34 MiB 1.18 MiB

Previous results on branch: antonis/expose-featureFlagsIntegration

Startup times

Revision Plain With Sentry Diff
5d0c968+dirty 373.22 ms 442.59 ms 69.37 ms

App size

Revision Plain With Sentry Diff
5d0c968+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.81 ms 1231.55 ms 7.74 ms
Size 2.63 MiB 3.80 MiB 1.17 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
f870f2d+dirty 1227.18 ms 1232.30 ms 5.12 ms
472960b+dirty 1213.96 ms 1222.58 ms 8.62 ms
fb47c4a+dirty 1231.00 ms 1231.33 ms 0.33 ms
7eff2d7+dirty 1225.34 ms 1234.53 ms 9.19 ms
3c99746+dirty 1215.12 ms 1222.31 ms 7.18 ms

App size

Revision Plain With Sentry Diff
f870f2d+dirty 2.63 MiB 3.79 MiB 1.15 MiB
472960b+dirty 2.63 MiB 3.79 MiB 1.15 MiB
fb47c4a+dirty 2.63 MiB 3.80 MiB 1.17 MiB
7eff2d7+dirty 2.63 MiB 3.79 MiB 1.16 MiB
3c99746+dirty 2.63 MiB 3.78 MiB 1.15 MiB

Previous results on branch: antonis/expose-featureFlagsIntegration

Startup times

Revision Plain With Sentry Diff
5d0c968+dirty 1195.68 ms 1216.08 ms 20.40 ms

App size

Revision Plain With Sentry Diff
5d0c968+dirty 2.63 MiB 3.80 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.65 ms 1227.51 ms -0.14 ms
Size 3.19 MiB 4.37 MiB 1.18 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
f870f2d+dirty 1230.08 ms 1238.88 ms 8.80 ms
472960b+dirty 1243.67 ms 1233.57 ms -10.11 ms
fb47c4a+dirty 1243.40 ms 1245.86 ms 2.46 ms
7eff2d7+dirty 1224.84 ms 1227.94 ms 3.10 ms
3c99746+dirty 1227.65 ms 1228.81 ms 1.16 ms

App size

Revision Plain With Sentry Diff
f870f2d+dirty 3.19 MiB 4.36 MiB 1.17 MiB
472960b+dirty 3.19 MiB 4.36 MiB 1.17 MiB
fb47c4a+dirty 3.19 MiB 4.37 MiB 1.18 MiB
7eff2d7+dirty 3.19 MiB 4.36 MiB 1.17 MiB
3c99746+dirty 3.19 MiB 4.35 MiB 1.16 MiB

Previous results on branch: antonis/expose-featureFlagsIntegration

Startup times

Revision Plain With Sentry Diff
5d0c968+dirty 1212.85 ms 1229.14 ms 16.29 ms

App size

Revision Plain With Sentry Diff
5d0c968+dirty 3.19 MiB 4.37 MiB 1.18 MiB

@antonis antonis marked this pull request as ready for review July 9, 2025 11:51
@antonis antonis requested a review from lucas-zimerman as a code owner July 9, 2025 11:51
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

Also quick tip: when sharing an event, make sure that the url has the event id and not only the issue id.
For example the link you shared only has the issue number, with that, when you open the url, it will point to the latest issue and not to the one you capture.

This is the correct url for this PR: https://sentry-sdks.sentry.io/issues/5005275690/events/1f25e354fc6f4fd8843c4aa9daebb4f5/?project=5428561

You can get the issue ID with the event id by clicking the Share issue button on the top of the issue.

@antonis
Copy link
Contributor Author

antonis commented Jul 10, 2025

Also quick tip: when sharing an event, make sure that the url has the event id and not only the issue id.
For example the link you shared only has the issue number, with that, when you open the url, it will point to the latest issue and not to the one you capture.

This is the correct url for this PR: https://sentry-sdks.sentry.io/issues/5005275690/events/1f25e354fc6f4fd8843c4aa9daebb4f5/?project=5428561

You can get the issue ID with the event id by clicking the Share issue button on the top of the issue.

TIL: Thank you @lucas-zimerman 🙇

@antonis antonis merged commit c99094a into v7 Jul 10, 2025
55 checks passed
@antonis antonis deleted the antonis/expose-featureFlagsIntegration branch July 10, 2025 10:14
antonis added a commit to getsentry/sentry-docs that referenced this pull request Oct 13, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*

Fixes getsentry/sentry-react-native#4590

Adds feature flags integration doc

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [ ] None: Not urgent, can wait up to 1 week+

Shipped in v7 with
getsentry/sentry-react-native#4984

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants