Feat: V7 - JavaScript V9 Add browser session integration #4732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction
|
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497 | 397.98 ms | 423.40 ms | 25.42 ms |
| e468cd4 | 403.30 ms | 404.98 ms | 1.68 ms |
| 987dc4d | 422.12 ms | 478.34 ms | 56.22 ms |
| 39a9ff3 | 428.71 ms | 429.00 ms | 0.29 ms |
| 35eb9e7 | 383.45 ms | 415.65 ms | 32.21 ms |
| 49f1a9c | 423.64 ms | 411.10 ms | -12.54 ms |
| 71f7309 | 412.45 ms | 431.62 ms | 19.18 ms |
| e54b1ed | 434.79 ms | 429.52 ms | -5.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| e468cd4 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 987dc4d | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 39a9ff3 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 35eb9e7 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 49f1a9c | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 71f7309 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| e54b1ed | 17.75 MiB | 20.10 MiB | 2.36 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 1215.41 ms | 1226.38 ms | 10.97 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
Previous results on branch: lz/jsv9/add-browserSessionIntegration
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 22e86ad+dirty | 1212.31 ms | 1210.38 ms | -1.93 ms |
| 1aa988e+dirty | 1220.29 ms | 1219.00 ms | -1.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 22e86ad+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 1aa988e+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 1231.84 ms | 1235.49 ms | 3.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
Previous results on branch: lz/jsv9/add-browserSessionIntegration
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 22e86ad+dirty | 1225.04 ms | 1210.44 ms | -14.60 ms |
| 1aa988e+dirty | 1216.29 ms | 1221.92 ms | 5.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 22e86ad+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 1aa988e+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 399.70 ms | 407.34 ms | 7.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9da5c4e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
Previous results on branch: lz/jsv9/add-browserSessionIntegration
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1aa988e+dirty | 408.25 ms | 410.33 ms | 2.08 ms |
| 22e86ad+dirty | 464.98 ms | 462.24 ms | -2.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1aa988e+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 22e86ad+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
antonis
reviewed
Apr 8, 2025
antonis
reviewed
Apr 8, 2025
antonis
reviewed
Apr 8, 2025
|
Looks good, just the changelog needs a minor fix. |
Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Web has a new integration for session tracking, this PR simply adds this integration when running on a non-mobile project and when
enableAutoSessionTrackingis set to true💡 Motivation and Context
Fixes: #4729
💚 How did you test it?
Tests, Locally
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps