Skip to content

Change Cold/Warm App Start span description to Cold/Warm Start #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Change Cold/Warm App Start span description to Cold/Warm Start #4636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@

To learn more about the available configuration options visit [the documentation](https://docs.sentry.io/platforms/react-native/manual-setup/expo/expo-sagp/).

### Changes

Change `Cold/Warm App Start` span description to `Cold/Warm Start` ([#4636](https://github.com/getsentry/sentry-react-native/pull/4636))

### Fixes

- Various crashes and issues of Session Replay on Android. See the Android SDK version bump for more details. ([#4529](https://github.com/getsentry/sentry-react-native/pull/4529))
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/js/tracing/integrations/appStart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export const appStartIntegration = ({
const op = appStart.type === 'cold' ? APP_START_COLD_OP : APP_START_WARM_OP;
const appStartSpanJSON: SpanJSON = createSpanJSON({
op,
description: appStart.type === 'cold' ? 'Cold App Start' : 'Warm App Start',
description: appStart.type === 'cold' ? 'Cold Start' : 'Warm Start',
start_timestamp: appStartTimestampSeconds,
timestamp: appStartEndTimestampSeconds,
trace_id: event.contexts.trace.trace_id,
Expand Down
36 changes: 18 additions & 18 deletions packages/core/test/tracing/integrations/appStart.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,15 @@ describe('App Start Integration', () => {

const actualEvent = await captureStandAloneAppStart();

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const bundleStartSpan = actualEvent!.spans!.find(
({ description }) => description === 'JS Bundle Execution Start',
);

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
span_id: expect.any(String),
description: 'Cold App Start',
description: 'Cold Start',
op: APP_START_COLD_OP,
data: {
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: APP_START_COLD_OP,
Expand Down Expand Up @@ -189,15 +189,15 @@ describe('App Start Integration', () => {

const actualEvent = await captureStandAloneAppStart();

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const bundleStartSpan = actualEvent!.spans!.find(
({ description }) => description === 'JS Bundle Execution Before React Root',
);

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
span_id: expect.any(String),
description: 'Cold App Start',
description: 'Cold Start',
op: APP_START_COLD_OP,
data: {
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: APP_START_COLD_OP,
Expand Down Expand Up @@ -228,13 +228,13 @@ describe('App Start Integration', () => {

const actualEvent = await captureStandAloneAppStart();

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const nativeSpan = actualEvent!.spans!.find(({ description }) => description === 'test native app start span');

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
span_id: expect.any(String),
description: 'Cold App Start',
description: 'Cold Start',
op: APP_START_COLD_OP,
data: {
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: APP_START_COLD_OP,
Expand Down Expand Up @@ -465,14 +465,14 @@ describe('App Start Integration', () => {

const actualEvent = await processEvent(getMinimalTransactionEvent());

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const bundleStartSpan = actualEvent!.spans!.find(
({ description }) => description === 'JS Bundle Execution Start',
);

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
description: 'Cold App Start',
description: 'Cold Start',
span_id: expect.any(String),
op: APP_START_COLD_OP,
origin: SPAN_ORIGIN_AUTO_APP_START,
Expand Down Expand Up @@ -505,14 +505,14 @@ describe('App Start Integration', () => {

const actualEvent = await processEvent(getMinimalTransactionEvent());

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const bundleStartSpan = actualEvent!.spans!.find(
({ description }) => description === 'JS Bundle Execution Before React Root',
);

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
description: 'Cold App Start',
description: 'Cold Start',
span_id: expect.any(String),
op: APP_START_COLD_OP,
origin: SPAN_ORIGIN_AUTO_APP_START,
Expand Down Expand Up @@ -545,14 +545,14 @@ describe('App Start Integration', () => {

const actualEvent = await processEvent(getMinimalTransactionEvent());

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const bundleStartSpan = actualEvent!.spans!.find(
({ description }) => description === 'JS Bundle Execution Before React Root',
);

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
description: 'Cold App Start',
description: 'Cold Start',
span_id: expect.any(String),
op: APP_START_COLD_OP,
origin: SPAN_ORIGIN_AUTO_APP_START,
Expand Down Expand Up @@ -586,12 +586,12 @@ describe('App Start Integration', () => {

const actualEvent = await processEvent(getMinimalTransactionEvent());

const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold App Start');
const appStartRootSpan = actualEvent!.spans!.find(({ description }) => description === 'Cold Start');
const nativeSpan = actualEvent!.spans!.find(({ description }) => description === 'test native app start span');

expect(appStartRootSpan).toEqual(
expect.objectContaining(<Partial<SpanJSON>>{
description: 'Cold App Start',
description: 'Cold Start',
span_id: expect.any(String),
op: APP_START_COLD_OP,
origin: SPAN_ORIGIN_AUTO_APP_START,
Expand Down Expand Up @@ -802,7 +802,7 @@ function expectEventWithAttachedColdAppStart({
spans: expect.arrayContaining<SpanJSON>([
{
op: APP_START_COLD_OP,
description: 'Cold App Start',
description: 'Cold Start',
start_timestamp: appStartTimeMilliseconds / 1000,
timestamp: expect.any(Number),
trace_id: expect.any(String),
Expand Down Expand Up @@ -856,7 +856,7 @@ function expectEventWithAttachedWarmAppStart({
spans: expect.arrayContaining<SpanJSON>([
{
op: APP_START_WARM_OP,
description: 'Warm App Start',
description: 'Warm Start',
start_timestamp: appStartTimeMilliseconds / 1000,
timestamp: expect.any(Number),
trace_id: expect.any(String),
Expand Down Expand Up @@ -913,7 +913,7 @@ function expectEventWithStandaloneColdAppStart(
spans: expect.arrayContaining<SpanJSON>([
{
op: APP_START_COLD_OP,
description: 'Cold App Start',
description: 'Cold Start',
start_timestamp: appStartTimeMilliseconds / 1000,
timestamp: expect.any(Number),
trace_id: expect.any(String),
Expand Down Expand Up @@ -962,7 +962,7 @@ function expectEventWithStandaloneWarmAppStart(
spans: expect.arrayContaining<SpanJSON>([
{
op: APP_START_WARM_OP,
description: 'Warm App Start',
description: 'Warm Start',
start_timestamp: appStartTimeMilliseconds / 1000,
timestamp: expect.any(Number),
trace_id: expect.any(String),
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/tracing/reactnavigation.ttid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ describe('React Navigation - TTID', () => {
type: 'transaction',
spans: expect.arrayContaining([
expect.objectContaining<Partial<SpanJSON>>({
description: 'Cold App Start',
description: 'Cold Start',
}),
expect.objectContaining<Partial<SpanJSON>>({
data: {
Expand Down Expand Up @@ -289,7 +289,7 @@ describe('React Navigation - TTID', () => {
type: 'transaction',
spans: expect.arrayContaining([
expect.objectContaining<Partial<SpanJSON>>({
description: 'Cold App Start',
description: 'Cold Start',
}),
expect.objectContaining<Partial<SpanJSON>>({
data: {
Expand Down Expand Up @@ -319,7 +319,7 @@ describe('React Navigation - TTID', () => {
type: 'transaction',
spans: expect.arrayContaining([
expect.objectContaining<Partial<SpanJSON>>({
description: 'Cold App Start',
description: 'Cold Start',
}),
]),
measurements: expect.objectContaining<Required<TransactionEvent>['measurements']>({
Expand Down
Loading