chore(sample): Adds Android 16KB support in the React Native Sample app #4623

antonis · 2025-03-05T09:09:39Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Adds Android 16KB page support in the React Native Sample app by bumping the following dependencies:

react-native-gesture-handler to 2.24.0 [Android] Add support for 16KB page size. software-mansion/react-native-gesture-handler#3412
react-native-reanimated to 3.17.1 [Android] Add support for 16KB page size software-mansion/react-native-reanimated#7037
react-native-screens to 4.8.0 [Android] Add support for 16KB page size software-mansion/react-native-screens#2702

💡 Motivation and Context

Follow up to the RN 0.77 Bump #4508 (comment)

💚 How did you test it?

Manually on a Pixel 9 Pro API 35 emulator with 16KB support that was failing to run the app before the changes.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

…rt 16KB - https://github.com/software-mansion/react-native-screens/releases/tag/4.8.0 - https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.24.0

# Conflicts: # samples/react-native/package.json

…are-mansion/react-native-reanimated#7037

github-actions · 2025-03-05T09:23:57Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	440.83 ms	474.69 ms	33.87 ms
Size	17.75 MiB	20.12 MiB	2.37 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`700cbf4`	425.56 ms	436.26 ms	10.70 ms
`3f05680`	397.91 ms	405.65 ms	7.74 ms
`7e87527`	425.56 ms	407.64 ms	-17.93 ms
`9672577`	416.34 ms	421.26 ms	4.92 ms
`2dc8f22`	435.67 ms	417.00 ms	-18.67 ms
`fc150fe`	414.15 ms	458.06 ms	43.91 ms
`1d86dd6`	405.14 ms	411.06 ms	5.92 ms
`c991c90`	418.78 ms	404.16 ms	-14.62 ms
`afe5fcb`	322.46 ms	353.04 ms	30.58 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms

App size

Revision	Plain	With Sentry	Diff
`700cbf4`	17.73 MiB	20.07 MiB	2.33 MiB
`3f05680`	17.75 MiB	20.11 MiB	2.37 MiB
`7e87527`	17.75 MiB	20.11 MiB	2.37 MiB
`9672577`	17.75 MiB	20.11 MiB	2.36 MiB
`2dc8f22`	17.75 MiB	20.11 MiB	2.37 MiB
`fc150fe`	17.75 MiB	20.11 MiB	2.37 MiB
`1d86dd6`	17.73 MiB	19.86 MiB	2.12 MiB
`c991c90`	17.75 MiB	20.11 MiB	2.36 MiB
`afe5fcb`	17.75 MiB	20.11 MiB	2.36 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB

Previous results on branch: antonis/sample-16kb

Startup times

Revision	Plain	With Sentry	Diff
`e4636d3`	389.29 ms	431.56 ms	42.27 ms

App size

Revision	Plain	With Sentry	Diff
`e4636d3`	17.75 MiB	20.12 MiB	2.37 MiB

github-actions · 2025-03-05T09:31:25Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	421.76 ms	417.28 ms	-4.48 ms
Size	7.15 MiB	8.39 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`205982c`+dirty	383.94 ms	424.98 ms	41.04 ms
`9672577`+dirty	391.55 ms	412.57 ms	21.02 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`d43a46b`+dirty	417.65 ms	472.98 ms	55.33 ms
`9385d74`+dirty	381.56 ms	416.02 ms	34.46 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`7143e6f`+dirty	338.60 ms	374.92 ms	36.32 ms
`e5bc97b`+dirty	409.10 ms	471.61 ms	62.51 ms
`4a6664f`+dirty	357.02 ms	394.91 ms	37.89 ms

App size

Revision	Plain	With Sentry	Diff
`205982c`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`9672577`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`d43a46b`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`9385d74`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`7143e6f`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`e5bc97b`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`4a6664f`+dirty	7.15 MiB	8.22 MiB	1.07 MiB

github-actions · 2025-03-05T10:03:58Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1218.57 ms	1226.55 ms	7.98 ms
Size	2.63 MiB	3.75 MiB	1.12 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8d251c2`+dirty	1220.17 ms	1225.21 ms	5.05 ms
`31fcca2`+dirty	1209.17 ms	1216.21 ms	7.04 ms
`13f280b`+dirty	1229.25 ms	1226.10 ms	-3.15 ms
`153419c`+dirty	1221.06 ms	1227.80 ms	6.73 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms
`d16beca`+dirty	1215.94 ms	1228.20 ms	12.27 ms
`1d7ae00`+dirty	1240.55 ms	1248.60 ms	8.05 ms
`5f03ae9`+dirty	1232.29 ms	1230.92 ms	-1.37 ms
`5571a20`+dirty	1203.57 ms	1204.57 ms	1.00 ms

App size

Revision	Plain	With Sentry	Diff
`8d251c2`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`31fcca2`+dirty	2.36 MiB	2.90 MiB	552.95 KiB
`13f280b`+dirty	2.36 MiB	3.10 MiB	753.43 KiB
`153419c`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB
`d16beca`+dirty	2.36 MiB	3.12 MiB	779.39 KiB
`1d7ae00`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`5f03ae9`+dirty	2.63 MiB	3.68 MiB	1.05 MiB
`5571a20`+dirty	2.36 MiB	2.92 MiB	569.93 KiB

Previous results on branch: antonis/sample-16kb

Startup times

Revision	Plain	With Sentry	Diff
`e4636d3`+dirty	1209.59 ms	1215.77 ms	6.18 ms

App size

Revision	Plain	With Sentry	Diff
`e4636d3`+dirty	2.63 MiB	3.75 MiB	1.12 MiB

github-actions · 2025-03-05T10:18:18Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.32 ms	1223.10 ms	-4.22 ms
Size	3.19 MiB	4.32 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8d251c2`+dirty	1221.19 ms	1227.12 ms	5.93 ms
`31fcca2`+dirty	1222.04 ms	1226.51 ms	4.47 ms
`13f280b`+dirty	1217.73 ms	1229.08 ms	11.35 ms
`153419c`+dirty	1225.12 ms	1221.31 ms	-3.82 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`d16beca`+dirty	1239.00 ms	1233.89 ms	-5.11 ms
`1d7ae00`+dirty	1240.33 ms	1239.51 ms	-0.82 ms
`5f03ae9`+dirty	1237.79 ms	1241.02 ms	3.23 ms
`5571a20`+dirty	1228.09 ms	1233.45 ms	5.36 ms

App size

Revision	Plain	With Sentry	Diff
`8d251c2`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`31fcca2`+dirty	2.92 MiB	3.46 MiB	557.31 KiB
`13f280b`+dirty	2.92 MiB	3.66 MiB	758.67 KiB
`153419c`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`d16beca`+dirty	2.92 MiB	3.69 MiB	790.48 KiB
`1d7ae00`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`5f03ae9`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`5571a20`+dirty	2.92 MiB	3.48 MiB	575.54 KiB

Previous results on branch: antonis/sample-16kb

Startup times

Revision	Plain	With Sentry	Diff
`e4636d3`+dirty	1225.98 ms	1229.19 ms	3.21 ms

App size

Revision	Plain	With Sentry	Diff
`e4636d3`+dirty	3.19 MiB	4.32 MiB	1.13 MiB

krystofwoldrich

LGTM 🚀

Ty!

antonis added 3 commits February 20, 2025 17:21

Update react-native-screens and react-native-gesture-handler to suppo…

1d01944

…rt 16KB - https://github.com/software-mansion/react-native-screens/releases/tag/4.8.0 - https://github.com/software-mansion/react-native-gesture-handler/releases/tag/2.24.0

Merge branch 'main' into antonis/sample-16kb

ad542c0

# Conflicts: # samples/react-native/package.json

Bumps react-native-reanimated to 3.17.1 that supports 16KB with softw…

1fae5f4

…are-mansion/react-native-reanimated#7037

antonis changed the title ~~chore(sample): Adds 16KB support in the React Native Sample app~~ chore(sample): Adds Android 16KB support in the React Native Sample app Mar 5, 2025

antonis marked this pull request as ready for review March 5, 2025 10:19

antonis requested review from krystofwoldrich and lucas-zimerman as code owners March 5, 2025 10:19

krystofwoldrich approved these changes Mar 5, 2025

View reviewed changes

Merge branch 'main' into antonis/sample-16kb

2a74449

antonis enabled auto-merge (squash) March 5, 2025 10:50

antonis merged commit c314a21 into main Mar 5, 2025
60 of 61 checks passed

antonis deleted the antonis/sample-16kb branch March 5, 2025 10:51

Uh oh!

chore(sample): Adds Android 16KB support in the React Native Sample app #4623

chore(sample): Adds Android 16KB support in the React Native Sample app #4623

Uh oh!

Conversation

antonis commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/sample-16kb

Startup times

App size

Uh oh!

github-actions bot commented Mar 5, 2025

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/sample-16kb

Startup times

App size

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/sample-16kb

Startup times

App size

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading