fix(appStart): Attach App Start spans to the first created not the first processed root span #4618
+54
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst processed root span
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 383.08 ms | 417.40 ms | 34.32 ms |
| b6f8ea2+dirty | 397.51 ms | 457.40 ms | 59.88 ms |
| 63ed251+dirty | 485.02 ms | 531.16 ms | 46.14 ms |
| 7f6950b+dirty | 432.72 ms | 476.91 ms | 44.19 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| de59d3a+dirty | 439.90 ms | 454.20 ms | 14.30 ms |
| 22e31b6+dirty | 295.75 ms | 346.73 ms | 50.98 ms |
| 15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
| 0677344+dirty | 288.40 ms | 391.44 ms | 103.04 ms |
| 60d7316+dirty | 475.43 ms | 535.26 ms | 59.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bda0cc+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| b6f8ea2+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 63ed251+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 7f6950b+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| de59d3a+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 22e31b6+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
| 15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
| 0677344+dirty | 7.15 MiB | 8.07 MiB | 949.80 KiB |
| 60d7316+dirty | 7.15 MiB | 8.38 MiB | 1.22 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 686b3bc+dirty | 1210.89 ms | 1221.14 ms | 10.25 ms |
| 3261206+dirty | 1219.49 ms | 1224.10 ms | 4.61 ms |
| 1d86dd6+dirty | 1249.71 ms | 1279.16 ms | 29.45 ms |
| d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
| 13f280b+dirty | 1229.25 ms | 1226.10 ms | -3.15 ms |
| 6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
| a5d86e1+dirty | 1242.47 ms | 1239.94 ms | -2.53 ms |
| 5852d77+dirty | 1210.16 ms | 1222.60 ms | 12.44 ms |
| d2c32bb+dirty | 1223.69 ms | 1229.49 ms | 5.80 ms |
| 18ce5e8+dirty | 1247.78 ms | 1242.85 ms | -4.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 686b3bc+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| 3261206+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 1d86dd6+dirty | 2.36 MiB | 2.89 MiB | 535.43 KiB |
| d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
| 13f280b+dirty | 2.36 MiB | 3.10 MiB | 753.43 KiB |
| 6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
| a5d86e1+dirty | 2.36 MiB | 3.10 MiB | 752.65 KiB |
| 5852d77+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| d2c32bb+dirty | 2.36 MiB | 3.08 MiB | 737.22 KiB |
| 18ce5e8+dirty | 2.36 MiB | 3.12 MiB | 778.65 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 686b3bc+dirty | 1219.65 ms | 1231.73 ms | 12.08 ms |
| 3261206+dirty | 1223.00 ms | 1226.06 ms | 3.06 ms |
| 1d86dd6+dirty | 1289.25 ms | 1293.36 ms | 4.11 ms |
| d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
| 13f280b+dirty | 1217.73 ms | 1229.08 ms | 11.35 ms |
| 6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
| a5d86e1+dirty | 1230.35 ms | 1222.47 ms | -7.88 ms |
| 5852d77+dirty | 1226.88 ms | 1236.38 ms | 9.50 ms |
| d2c32bb+dirty | 1244.00 ms | 1245.77 ms | 1.77 ms |
| 18ce5e8+dirty | 1244.67 ms | 1242.96 ms | -1.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 686b3bc+dirty | 3.19 MiB | 4.31 MiB | 1.12 MiB |
| 3261206+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
| 1d86dd6+dirty | 2.92 MiB | 3.44 MiB | 538.27 KiB |
| d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
| 13f280b+dirty | 2.92 MiB | 3.66 MiB | 758.67 KiB |
| 6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
| a5d86e1+dirty | 2.92 MiB | 3.66 MiB | 757.10 KiB |
| 5852d77+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
| d2c32bb+dirty | 2.92 MiB | 3.64 MiB | 742.84 KiB |
| 18ce5e8+dirty | 2.92 MiB | 3.69 MiB | 789.94 KiB |
antonis
approved these changes
Mar 4, 2025
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b0298 | 427.50 ms | 428.10 ms | 0.60 ms |
| 62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| d053743 | 429.96 ms | 444.20 ms | 14.24 ms |
| 5bb8d5f | 431.21 ms | 459.40 ms | 28.19 ms |
| 488c9c5 | 461.57 ms | 475.62 ms | 14.05 ms |
| 57448c5 | 443.47 ms | 440.20 ms | -3.26 ms |
| 10e6a21 | 377.96 ms | 406.04 ms | 28.08 ms |
| 0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
| 60d7316 | 418.46 ms | 414.12 ms | -4.34 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b0298 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| d053743 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 5bb8d5f | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| 488c9c5 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 57448c5 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 10e6a21 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| 60d7316 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
krystofwoldrich
deleted the
fix-attach-app-start-to-the-first-started-root-span
branch
krystofwoldrich
added a commit
that referenced
this pull request
Mar 11, 2025
…rst processed root span (#4618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes the app start being attached to the first started not first processed transaction.
The first started transaction doesn't have to end first.
💡 Motivation and Context
💚 How did you test it?
unit tests + e2e test coming in follow up PR
📝 Checklist
sendDefaultPIIis enabled