Skip to content

feat(feedback): Align secondary buttons with the web #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat(feedback): Align secondary buttons with the web #4572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a58e199
Align secondary buttons with the web
antonis Feb 20, 2025
9ba38f5
Update snapshots
antonis Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/core/src/js/feedback/FeedbackWidget.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ const defaultStyles: FeedbackWidgetStyles = {
color: FOREGROUND_COLOR,
},
screenshotButton: {
backgroundColor: '#eee',
backgroundColor: BACKGROUND_COLOR,
padding: 15,
borderRadius: 5,
alignItems: 'center',
flex: 1,
borderWidth: 1,
borderColor: BORDER_COLOR,
},
screenshotContainer: {
flexDirection: 'row',
Expand All @@ -61,7 +63,7 @@ const defaultStyles: FeedbackWidgetStyles = {
marginRight: 10,
},
screenshotText: {
color: '#333',
color: FOREGROUND_COLOR,
fontSize: 16,
},
submitButton: {
Expand All @@ -76,8 +78,12 @@ const defaultStyles: FeedbackWidgetStyles = {
fontSize: 18,
},
cancelButton: {
paddingVertical: 15,
backgroundColor: BACKGROUND_COLOR,
padding: 15,
borderRadius: 5,
alignItems: 'center',
borderWidth: 1,
borderColor: BORDER_COLOR,
},
cancelText: {
color: FOREGROUND_COLOR,
Expand Down
36 changes: 28 additions & 8 deletions packages/core/test/feedback/__snapshots__/FeedbackWidget.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,8 +761,12 @@ exports[`FeedbackWidget matches the snapshot with custom texts 1`] = `
style={
{
"alignItems": "center",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"opacity": 1,
"paddingVertical": 15,
"padding": 15,
}
}
>
Expand Down Expand Up @@ -980,8 +984,10 @@ exports[`FeedbackWidget matches the snapshot with custom texts and screenshot bu
style={
{
"alignItems": "center",
"backgroundColor": "#eee",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"flex": 1,
"opacity": 1,
"padding": 15,
Expand All @@ -991,7 +997,7 @@ exports[`FeedbackWidget matches the snapshot with custom texts and screenshot bu
<Text
style={
{
"color": "#333",
"color": "#2b2233",
"fontSize": 16,
}
}
Expand Down Expand Up @@ -1081,8 +1087,12 @@ exports[`FeedbackWidget matches the snapshot with custom texts and screenshot bu
style={
{
"alignItems": "center",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"opacity": 1,
"paddingVertical": 15,
"padding": 15,
}
}
>
Expand Down Expand Up @@ -1340,8 +1350,12 @@ exports[`FeedbackWidget matches the snapshot with default configuration 1`] = `
style={
{
"alignItems": "center",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"opacity": 1,
"paddingVertical": 15,
"padding": 15,
}
}
>
Expand Down Expand Up @@ -1559,8 +1573,10 @@ exports[`FeedbackWidget matches the snapshot with default configuration and scre
style={
{
"alignItems": "center",
"backgroundColor": "#eee",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"flex": 1,
"opacity": 1,
"padding": 15,
Expand All @@ -1570,7 +1586,7 @@ exports[`FeedbackWidget matches the snapshot with default configuration and scre
<Text
style={
{
"color": "#333",
"color": "#2b2233",
"fontSize": 16,
}
}
Expand Down Expand Up @@ -1660,8 +1676,12 @@ exports[`FeedbackWidget matches the snapshot with default configuration and scre
style={
{
"alignItems": "center",
"backgroundColor": "#ffffff",
"borderColor": "rgba(41, 35, 47, 0.13)",
"borderRadius": 5,
"borderWidth": 1,
"opacity": 1,
"paddingVertical": 15,
"padding": 15,
}
}
>
Expand Down
Loading