- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 354
internal(sample-rn): Add header and message envelope tests #4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            krystofwoldrich
  merged 7 commits into
  capture-app-start-errors
from
kw/add-mocked-relay
  
      
      
   
  Feb 17, 2025 
      
    
                
     Merged
            
            internal(sample-rn): Add header and message envelope tests #4536
                    krystofwoldrich
  merged 7 commits into
  capture-app-start-errors
from
kw/add-mocked-relay
  
      
      
   
  Feb 17, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Android (legacy) Performance metrics 🚀
 | 
| iOS (legacy) Performance metrics 🚀
 
 | 
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| b75148e+dirty | 1221.53 ms | 1220.85 ms | -0.68 ms | 
| 208f4af+dirty | 1209.44 ms | 1217.13 ms | 7.70 ms | 
| 1a89392+dirty | 1220.12 ms | 1216.69 ms | -3.43 ms | 
| 18a5066+dirty | 1218.00 ms | 1212.27 ms | -5.73 ms | 
| 5625ce7+dirty | 1226.98 ms | 1217.77 ms | -9.21 ms | 
| 555070f+dirty | 1213.59 ms | 1217.79 ms | 4.20 ms | 
| b6d933c+dirty | 1217.71 ms | 1220.58 ms | 2.87 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| b75148e+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB | 
| 208f4af+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB | 
| 1a89392+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
| 18a5066+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
| 5625ce7+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
| 555070f+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB | 
| b6d933c+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
Previous results on branch: kw/add-mocked-relay
Startup times
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 1226.88 ms | 1225.06 ms | -1.82 ms | 
| 1a4f5c0+dirty | 1218.98 ms | 1207.94 ms | -11.04 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
| 1a4f5c0+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB | 
| Android (new) Performance metrics 🚀
 
 | 
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 208f4af+dirty | 346.93 ms | 402.77 ms | 55.84 ms | 
| 18a5066+dirty | 370.06 ms | 414.10 ms | 44.04 ms | 
| 1a89392+dirty | 425.56 ms | 530.65 ms | 105.09 ms | 
| 5625ce7+dirty | 358.15 ms | 416.65 ms | 58.50 ms | 
| b6d933c+dirty | 398.43 ms | 456.62 ms | 58.19 ms | 
| 555070f+dirty | 388.25 ms | 424.44 ms | 36.19 ms | 
| b75148e+dirty | 428.91 ms | 461.26 ms | 32.35 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 208f4af+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| 18a5066+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| 1a89392+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| 5625ce7+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| b6d933c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| 555070f+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| b75148e+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
Previous results on branch: kw/add-mocked-relay
Startup times
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 390.80 ms | 434.96 ms | 44.16 ms | 
| 1a4f5c0+dirty | 400.89 ms | 382.91 ms | -17.98 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| 1a4f5c0+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB | 
| iOS (new) Performance metrics 🚀
 
 | 
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| b75148e+dirty | 1202.72 ms | 1212.04 ms | 9.32 ms | 
| 208f4af+dirty | 1213.08 ms | 1223.82 ms | 10.73 ms | 
| 1a89392+dirty | 1229.00 ms | 1234.78 ms | 5.78 ms | 
| 18a5066+dirty | 1244.20 ms | 1251.54 ms | 7.34 ms | 
| 5625ce7+dirty | 1219.73 ms | 1223.80 ms | 4.07 ms | 
| 555070f+dirty | 1223.61 ms | 1227.57 ms | 3.96 ms | 
| b6d933c+dirty | 1228.02 ms | 1235.32 ms | 7.30 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| b75148e+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB | 
| 208f4af+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB | 
| 1a89392+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
| 18a5066+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
| 5625ce7+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
| 555070f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB | 
| b6d933c+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
Previous results on branch: kw/add-mocked-relay
Startup times
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 1212.33 ms | 1213.71 ms | 1.38 ms | 
| 1a4f5c0+dirty | 1218.60 ms | 1205.28 ms | -13.33 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 5874841+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
| 1a4f5c0+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB | 
      
        
      
      
  
    10 tasks
  
      
        
      
      
  
    1 task
  
              
                    antonis
  
              
              approved these changes
              
                  
                    Feb 14, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🧪 🚀
    
          Base automatically changed from
    
      add-detox-to-sample
     to
    
      capture-app-start-errors
    
    February 14, 2025 15:27     
    
cf00d4d
      into
      
  
    capture-app-start-errors
  
    
        67 of 68 checks passed
      
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
📜 Description
This PR adds E2E tests for envelope header and message content. Testing the sample app which is using the new init from file.
Based on #4536
💚 How did you test it?
ci, run tests locally
#skip-changelog