feat(feedback): Pull down to cancel #4534

antonis · 2025-02-13T17:00:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Based on #4524

📜 Description

Implements pull down to cancel for feedback modal.

💡 Motivation and Context

See #4302

💚 How did you test it?

Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

…tive-image-picker`

…ration

github-actions · 2025-02-13T17:14:50Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	455.44 ms	464.20 ms	8.75 ms
Size	17.75 MiB	20.12 MiB	2.38 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`3e4cdf5`	462.35 ms	474.96 ms	12.61 ms
`6b1624f`	462.78 ms	465.13 ms	2.35 ms
`df05370`	477.62 ms	491.63 ms	14.00 ms
`e5d5735`	452.70 ms	453.04 ms	0.34 ms
`0325426`	477.32 ms	457.43 ms	-19.89 ms
`269c976`	448.08 ms	428.86 ms	-19.22 ms
`2646c98`	429.98 ms	421.63 ms	-8.35 ms
`9402883`	448.53 ms	468.73 ms	20.20 ms
`894ebb0`	497.45 ms	545.04 ms	47.60 ms
`8cb898b`	438.83 ms	420.58 ms	-18.25 ms

App size

Revision	Plain	With Sentry	Diff
`3e4cdf5`	17.75 MiB	20.12 MiB	2.37 MiB
`6b1624f`	17.75 MiB	20.12 MiB	2.37 MiB
`df05370`	17.75 MiB	20.12 MiB	2.37 MiB
`e5d5735`	17.75 MiB	20.12 MiB	2.37 MiB
`0325426`	17.75 MiB	20.12 MiB	2.37 MiB
`269c976`	17.75 MiB	20.12 MiB	2.37 MiB
`2646c98`	17.75 MiB	20.12 MiB	2.37 MiB
`9402883`	17.75 MiB	20.12 MiB	2.37 MiB
`894ebb0`	17.75 MiB	20.12 MiB	2.37 MiB
`8cb898b`	17.75 MiB	20.12 MiB	2.37 MiB

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

Revision	Plain	With Sentry	Diff
`d0692d8`	418.98 ms	434.96 ms	15.98 ms

App size

Revision	Plain	With Sentry	Diff
`d0692d8`	17.75 MiB	20.12 MiB	2.37 MiB

github-actions · 2025-02-13T17:29:05Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1231.51 ms	1231.81 ms	0.30 ms
Size	2.63 MiB	3.75 MiB	1.12 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	1218.51 ms	1218.92 ms	0.41 ms
`269c976`+dirty	1210.02 ms	1204.46 ms	-5.56 ms
`e5d5735`+dirty	1222.02 ms	1222.22 ms	0.20 ms
`df05370`+dirty	1209.92 ms	1216.55 ms	6.63 ms
`894ebb0`+dirty	1224.33 ms	1214.45 ms	-9.89 ms
`9402883`+dirty	1219.65 ms	1217.94 ms	-1.72 ms
`77e88fc`+dirty	1224.55 ms	1232.41 ms	7.86 ms
`3e4cdf5`+dirty	1222.53 ms	1224.42 ms	1.89 ms
`0325426`+dirty	1228.88 ms	1229.92 ms	1.04 ms
`8cb898b`+dirty	1221.40 ms	1231.78 ms	10.37 ms

App size

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`269c976`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`e5d5735`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`df05370`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`894ebb0`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`9402883`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`77e88fc`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`3e4cdf5`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`0325426`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`8cb898b`+dirty	2.63 MiB	3.71 MiB	1.08 MiB

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	1221.78 ms	1224.60 ms	2.82 ms

App size

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	2.63 MiB	3.71 MiB	1.08 MiB

github-actions · 2025-02-13T17:34:19Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	411.58 ms	415.57 ms	3.99 ms
Size	7.15 MiB	8.39 MiB	1.24 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`3e4cdf5`+dirty	642.13 ms	702.23 ms	60.10 ms
`269c976`+dirty	395.13 ms	438.37 ms	43.24 ms
`8cb898b`+dirty	393.33 ms	416.20 ms	22.87 ms
`894ebb0`+dirty	417.81 ms	499.74 ms	81.93 ms
`2646c98`+dirty	415.13 ms	438.41 ms	23.28 ms
`9402883`+dirty	436.49 ms	518.94 ms	82.45 ms
`6b1624f`+dirty	382.17 ms	441.00 ms	58.83 ms
`0325426`+dirty	418.89 ms	485.00 ms	66.11 ms
`df05370`+dirty	395.08 ms	430.38 ms	35.30 ms
`77e88fc`+dirty	358.67 ms	346.20 ms	-12.47 ms

App size

Revision	Plain	With Sentry	Diff
`3e4cdf5`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`269c976`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`8cb898b`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`894ebb0`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`2646c98`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`9402883`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`6b1624f`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`0325426`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`df05370`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`77e88fc`+dirty	7.15 MiB	8.39 MiB	1.24 MiB

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	400.17 ms	430.28 ms	30.11 ms

App size

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	7.15 MiB	8.39 MiB	1.24 MiB

github-actions · 2025-02-13T17:38:10Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1233.49 ms	1236.29 ms	2.80 ms
Size	3.19 MiB	4.32 MiB	1.13 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	1239.94 ms	1246.90 ms	6.96 ms
`269c976`+dirty	1223.29 ms	1222.90 ms	-0.39 ms
`e5d5735`+dirty	1217.78 ms	1221.80 ms	4.02 ms
`df05370`+dirty	1221.14 ms	1216.60 ms	-4.55 ms
`894ebb0`+dirty	1210.94 ms	1202.08 ms	-8.85 ms
`9402883`+dirty	1217.71 ms	1213.02 ms	-4.69 ms
`77e88fc`+dirty	1218.79 ms	1220.00 ms	1.21 ms
`3e4cdf5`+dirty	1213.36 ms	1221.31 ms	7.95 ms
`0325426`+dirty	1210.17 ms	1216.37 ms	6.20 ms
`8cb898b`+dirty	1209.39 ms	1207.57 ms	-1.82 ms

App size

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`269c976`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`e5d5735`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`df05370`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`894ebb0`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`9402883`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`77e88fc`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`3e4cdf5`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`0325426`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`8cb898b`+dirty	3.19 MiB	4.28 MiB	1.09 MiB

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	1200.51 ms	1209.06 ms	8.55 ms

App size

Revision	Plain	With Sentry	Diff
`d0692d8`+dirty	3.19 MiB	4.27 MiB	1.09 MiB

…ive gestures

github-actions · 2025-02-14T16:33:32Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3238fe0

krystofwoldrich · 2025-02-14T16:35:43Z

packages/core/src/js/feedback/FeedbackFormManager.tsx

+
+  private _panResponder = PanResponder.create({
+    onStartShouldSetPanResponder: (evt, _gestureState) => {
+      // On Android allow pulling down only from the top to avoid breaking native gestures


Thank you for including here the reason why.

krystofwoldrich

Looks great. Thank you.

antonis added 27 commits January 30, 2025 14:28

Disable bouncing

fe3dc15

Add modal ui appearance

72eef2d

Update snapshot tests

ccc808b

Fix bottom margin

fd47fd2

Merge branch 'feedback-ui' into antonis/feedback-modal-ui

dcc5d3b

Fix sheet height

9ecd8a2

Remove extra modal border

05f94f8

Do not expose modal styles

d88a599

Animate background color

ce1de86

Avoid keyboard in modal

a7a4e56

Merge branch 'feedback-ui' into antonis/feedback-modal-ui

8779886

Merge branch 'feedback-ui' into antonis/feedback-modal-ui

ae80f7d

Merge branch 'feedback-ui' into antonis/feedback-modal-ui

488658e

Use Image Picker interface matching expo-image-picker and `react-na…

c4d502e

…tive-image-picker`

Update samples to pass the ImagePicker library implementation

1b74b45

Merge branch 'feedback-ui' into antonis/feedback-ui-imagepicker-integ…

1d8a0db

…ration

Get image data from uri

a0f4a77

Add early return and dev note

357dea8

Adds tests

192220b

Adds sample expo plugin configuration

c3991ff

Merge branch 'feedback-ui' into antonis/feedback-ui-imagepicker-integ…

91e96de

…ration

Update media type for expo

6666cf6

Update media type for rn

d1e5107

Add native implementation for getDataFromUri

d780fc1

Bumped to the latest react-native-image-picker version 8

85dff80

Add missing null in return type

e92fea6

Pull down to cancel on iOS

becede1

Base automatically changed from antonis/feedback-ui-imagepicker-integration to feedback-ui February 14, 2025 09:00

krystofwoldrich mentioned this pull request Feb 14, 2025

[EPIC] Feedback Widget for React Native #4302

Closed

26 tasks

antonis added 2 commits February 14, 2025 11:18

Merge branch 'feedback-ui' into antonis/feedback-ios-pull-down-to-cancel

529b703

On Android allow pulling down only from the top to avoid breaking nat…

3238fe0

…ive gestures

antonis changed the title ~~Feedback UI: Pull down to cancel (iOS)~~ Feedback UI: Pull down to cancel Feb 14, 2025

antonis marked this pull request as ready for review February 14, 2025 10:02

antonis requested review from krystofwoldrich and lucas-zimerman as code owners February 14, 2025 10:02

antonis mentioned this pull request Feb 14, 2025

feat: Feedback Widget Beta for React Native #4435

Merged

10 tasks

antonis changed the title ~~Feedback UI: Pull down to cancel~~ feat(feedback): Pull down to cancel Feb 14, 2025

krystofwoldrich reviewed Feb 14, 2025

View reviewed changes

krystofwoldrich approved these changes Feb 14, 2025

View reviewed changes

antonis merged commit 874b2a2 into feedback-ui Feb 17, 2025
71 checks passed

antonis deleted the antonis/feedback-ios-pull-down-to-cancel branch February 17, 2025 09:28

Uh oh!

feat(feedback): Pull down to cancel #4534

feat(feedback): Pull down to cancel #4534

Uh oh!

Conversation

antonis commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-ios-pull-down-to-cancel

Startup times

App size

Uh oh!

github-actions bot commented Feb 14, 2025

Uh oh!

krystofwoldrich Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading