chore(sample-rn): Always use fhe file option (including auto init) #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init-native-from-file
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
krystofwoldrich
changed the base branch from
capture-app-start-errors
to
kw-auto-init-native-from-file
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b75148e+dirty | 1221.53 ms | 1220.85 ms | -0.68 ms |
| 208f4af+dirty | 1209.44 ms | 1217.13 ms | 7.70 ms |
| 1a89392+dirty | 1220.12 ms | 1216.69 ms | -3.43 ms |
| 18a5066+dirty | 1218.00 ms | 1212.27 ms | -5.73 ms |
| 5625ce7+dirty | 1226.98 ms | 1217.77 ms | -9.21 ms |
| 555070f+dirty | 1213.59 ms | 1217.79 ms | 4.20 ms |
| b6d933c+dirty | 1217.71 ms | 1220.58 ms | 2.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b75148e+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 208f4af+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 1a89392+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 18a5066+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 5625ce7+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 555070f+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| b6d933c+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
Android (new) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b75148e+dirty | 1202.72 ms | 1212.04 ms | 9.32 ms |
| 208f4af+dirty | 1213.08 ms | 1223.82 ms | 10.73 ms |
| 1a89392+dirty | 1229.00 ms | 1234.78 ms | 5.78 ms |
| 18a5066+dirty | 1244.20 ms | 1251.54 ms | 7.34 ms |
| 5625ce7+dirty | 1219.73 ms | 1223.80 ms | 4.07 ms |
| 555070f+dirty | 1223.61 ms | 1227.57 ms | 3.96 ms |
| b6d933c+dirty | 1228.02 ms | 1235.32 ms | 7.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b75148e+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
| 208f4af+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 1a89392+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| 18a5066+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| 5625ce7+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| 555070f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| b6d933c+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
antonis
approved these changes
Feb 13, 2025
Base automatically changed from
kw-auto-init-native-from-file
to
capture-app-start-errors
February 13, 2025 15:00
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1a89392 | 412.59 ms | 424.69 ms | 12.10 ms |
| 555070f | 438.67 ms | 428.30 ms | -10.37 ms |
| 5625ce7 | 476.74 ms | 488.24 ms | 11.50 ms |
| b75148e | 440.04 ms | 421.36 ms | -18.68 ms |
| 208f4af | 439.23 ms | 427.31 ms | -11.92 ms |
| b6d933c | 442.52 ms | 461.82 ms | 19.30 ms |
| 18a5066 | 427.89 ms | 436.47 ms | 8.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1a89392 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 555070f | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 5625ce7 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| b75148e | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 208f4af | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| b6d933c | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 18a5066 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the auto init behavior for testing purposes in the react native sample.
Depending on the runtime/build flags the native SDK initialize on app start or auto using JS. The options form the file are always used.
#skip-changelog