misc(sample): Change RN Sample to use native file init by default #4522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
krystofwoldrich
changed the base branch from
main
to
capture-app-start-errors
lucas-zimerman
approved these changes
Feb 10, 2025
antonis
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thank you for adding this option in the sample @krystofwoldrich 🙇
The code changes LGTM and I didn't notice any weird behaviour testing the sample app on iOS and Android 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR changes the RN sample to use the new native init apis by default.
Secondary this PR adds simple build/start options to change to the auto init behavior from JS.
This will be used for testing, where we will need to test that both ways of init result in the same SDK behaviour.
💚 How did you test it?
sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog