Skip to content

chore(deps): Bumps sample app to RN 0.77.0 #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 6, 2025
Merged

chore(deps): Bumps sample app to RN 0.77.0 #4508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
545f674
Upgrade core to 0.77.0
antonis Feb 5, 2025
268cd56
Update lockfile
antonis Feb 5, 2025
aa3b26f
Upgrade e2e tests to 0.77.0
antonis Feb 5, 2025
52d228e
Bump react-native sample to RN0.77
antonis Feb 5, 2025
c7cc652
Update lockfile
antonis Feb 5, 2025
31075e3
Fixes Lint issue
antonis Feb 5, 2025
c945b96
Fixes iOS Runtime crash
antonis Feb 5, 2025
338a238
Lint: empty line
antonis Feb 5, 2025
6f27c67
Merge branch 'main' into antonis/rn-0.77-e2e
antonis Feb 5, 2025
b41ad44
Merge branch 'antonis/rn-0.77-e2e' into antonis/rn-0.77-sample
antonis Feb 5, 2025
b4c08e8
Merge branch 'main' into antonis/rn-0.77-sample
krystofwoldrich Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/react-native/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ buildscript {
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 34
ndkVersion = "26.1.10909125"
kotlinVersion = "1.9.24"
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
}
repositories {
google()
Expand Down
4 changes: 4 additions & 0 deletions samples/react-native/ios/sentryreactnativesample/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#import <RCTAppDelegate+Protected.h>
#import <React/CoreModulesPlugins.h>
#import <React/RCTBundleURLProvider.h>
#import <ReactAppDependencyProvider/RCTAppDependencyProvider.h>
#import <ReactCommon/RCTTurboModuleManager.h>

#ifdef RCT_NEW_ARCH_ENABLED
Expand Down Expand Up @@ -59,6 +60,9 @@ - (BOOL)application:(UIApplication *)application
// [self initializeSentry];

self.moduleName = @"sentry-react-native-sample";

self.dependencyProvider = [RCTAppDependencyProvider new];

// You can add your custom initial props in the dictionary below.
// They will be passed down to the ViewController used by React
self.initialProps = @{};
Expand Down
45 changes: 23 additions & 22 deletions samples/react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,44 +21,45 @@
"build-android-release-splits-flavors": "export SENTRY_SAMPLE_ENABLE_ABI_SPLIT=true; export SENTRY_SAMPLE_ENABLE_FLAVORS=true; cd android; ./gradlew assembleRelease; cd .."
},
"dependencies": {
"@react-navigation/bottom-tabs": "^7.0.4",
"@react-navigation/native": "^7.0.3",
"@react-navigation/native-stack": "^7.0.3",
"@react-navigation/stack": "^7.0.3",
"@react-navigation/bottom-tabs": "^7.2.0",
"@react-navigation/native": "^7.0.14",
"@react-navigation/native-stack": "^7.2.0",
"@react-navigation/stack": "^7.1.1",
"@sentry/react-native": "6.6.0",
"delay": "^6.0.0",
"react": "18.3.1",
"react-native": "0.76.3",
"react-native-gesture-handler": "^2.21.1",
"react-native-reanimated": "3.16.1",
"react-native-safe-area-context": "4.14.0",
"react-native-screens": "4.1.0",
"react-native-svg": "^15.9.0",
"react-native": "0.77.0",
"react-native-gesture-handler": "^2.22.1",
"react-native-reanimated": "3.16.7",
"react-native-safe-area-context": "5.2.0",
"react-native-screens": "4.6.0",
"react-native-svg": "^15.11.1",
"react-native-vector-icons": "^10.2.0",
"react-native-webview": "^13.12.3",
"react-native-webview": "^13.13.2",
"react-redux": "^8.1.3",
"redux": "^4.2.1"
},
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "15.0.1",
"@react-native-community/cli-platform-android": "15.0.1",
"@react-native-community/cli-platform-ios": "15.0.1",
"@react-native/babel-preset": "0.76.3",
"@react-native/eslint-config": "0.76.3",
"@react-native/metro-config": "0.76.3",
"@react-native/typescript-config": "0.76.3",
"@babel/core": "^7.26.7",
"@babel/preset-env": "^7.26.7",
"@babel/runtime": "^7.26.7",
"@react-native-community/cli": "15.1.3",
"@react-native-community/cli-platform-android": "15.1.3",
"@react-native-community/cli-platform-ios": "15.1.3",
"@react-native/babel-preset": "0.77.0",
"@react-native/eslint-config": "0.77.0",
"@react-native/metro-config": "0.77.0",
"@react-native/typescript-config": "0.77.0",
"@sentry/babel-plugin-component-annotate": "^2.18.0",
"@types/react": "^18.2.65",
"@types/react-native-vector-icons": "^6.4.18",
"@types/react-test-renderer": "^18.0.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"babel-jest": "^29.2.1",
"babel-jest": "^29.6.3",
"babel-plugin-module-resolver": "^5.0.0",
"eslint": "^8.19.0",
"eslint-plugin-ft-flow": "^3.0.11",
Copy link
Contributor

@krystofwoldrich krystofwoldrich Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this devDependency?

Copy link
Contributor Author

@antonis antonis Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a lint error pointing to this dependency after the eslint-config bump

  ESLint couldn't find the plugin "eslint-plugin-ft-flow".
  
  (The package "eslint-plugin-ft-flow" was not found when loaded as a Node module from the directory "/home/runner/work/sentry-react-native/sentry-react-native/samples/react-native".)
  
  It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
  
      npm install eslint-plugin-ft-flow@latest --save-dev
  
  The plugin "eslint-plugin-ft-flow" was referenced from the config file in ".eslintrc.js » @react-native/eslint-config#overrides[0]".

"jest": "^29.6.3",
"patch-package": "^8.0.0",
"prettier": "2.8.8",
Expand Down
Loading
Loading