feat(experimental): Add native startWithConfigureOptions for Apple platforms
#4444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89 | 448.65 ms | 437.68 ms | -10.97 ms |
| aca58c3 | 466.10 ms | 450.37 ms | -15.73 ms |
| 6326ab7 | 445.10 ms | 434.72 ms | -10.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| aca58c3 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 6326ab7 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
Android (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
This was referenced Jan 15, 2025
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
Base automatically changed from
kw-ref-ios-sdk-init
to
capture-app-start-errors
January 21, 2025 16:22
antonis
approved these changes
Jan 22, 2025
krystofwoldrich
merged commit 7144a64
into
capture-app-start-errors
65 of 66 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds
RNSentrySDK.startWithConfigureOptionspublic method for initializing RNSentry.This method should be used in RN application where the developer wants to manually initialize the native SDK. This is drop in replacement from
SentrySDK.startWithConfigureOptionsexposed bysentry-cocoa. The reason to useRNSentrySDKto initialize the SDK is user convenience as this automatically applies sensible default for RN application.This is an intermediate step towards initializing from RNSentry from
sentry.options.json.💡 Motivation and Context
sentry.options.jsonduring cocoa init #4447💚 How did you test it?
sample app, unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps