-
-
Notifications
You must be signed in to change notification settings - Fork 354
(2.1) Handles captureFeedback errors #4364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2.1) Handles captureFeedback errors #4364
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
…359-Feedback-Form-NetworkError
…359-Feedback-Form-NetworkError
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.
See impl of sendEnvelope in RN
| return Promise.resolve({}); |
I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).
We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.
|
Thank you for the feedback @krystofwoldrich and the explanation on why not to use
Makes sense 👍 Updated with c014ccc |
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for the PR!
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the changes and refs.
Looks good! 🚀
📢 Type of change
Based on #4328
📜 Description
onFormOpen,onSubmitSuccess,onSubmitError,onFormSubmitted💡 Motivation and Context
Fixes #4359
💚 How did you test it?
Manual testing, Unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog