fix(replay): browserReplayIntegration should not be included by default #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
antonis
approved these changes
Nov 25, 2024
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM! Thank you for back-porting this fix 🙇
l: The Lint failure could be fixed by formatting the sdk.test.ts.
I think the rest of the CI check failures are unrelated with this PR (signing issues, testing device availability etc).
Contributor
Author
|
Sadly, the v5 CI is out of date, we have to fix it first, unrelated to changes in this PR. |
lucas-zimerman
approved these changes
Nov 27, 2024
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserReplayIntegrationshould not be included by default #4270 for v5