fix(gradle): DISABLE_NATIVE_UPLOAD should not affect JS source maps upload #4263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
9 tasks
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
antonis
added a commit
that referenced
this pull request
Nov 12, 2024
* Aligns Android autoupload logic with iOS * fix(gradle): DISABLE_NATIVE_UPLOAD should not affect JS source maps upload (#4263) --------- Co-authored-by: Krystof Woldrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The new disable native upload flag was not released yet.
This fixes case when the native upload is disabled but still JS source maps should be uploaded.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled#skip-changelog