fix(ci): Fix iOS builds failing Hermes cocoapods #3592

krystofwoldrich · 2024-02-12T21:48:33Z

📢 Type of change

Bugfix

📜 Description

failing ios cocoapods caused by New error when installing pods in 1.15: File exists @ syserr_fail2_in CocoaPods/CocoaPods#12226 (comment)
This PR forces the latest 1.15.2 cocoapods for the sample application CI and RN 0.73 e2e tests. As with previous Cocoapods versions, the Hermes pod will crash the pod install.

💚 How did you test it?

ci, could not reproduce locally

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2024-02-12T21:58:41Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	384.27 ms	397.14 ms	12.87 ms
Size	17.73 MiB	19.90 MiB	2.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`2534337`	394.15 ms	415.12 ms	20.97 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`e2b64fe`	316.88 ms	330.23 ms	13.35 ms
`3853f43`	329.68 ms	346.32 ms	16.64 ms

App size

Revision	Plain	With Sentry	Diff
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`2534337`	17.73 MiB	19.84 MiB	2.11 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`e2b64fe`	17.73 MiB	19.80 MiB	2.07 MiB
`3853f43`	17.73 MiB	19.81 MiB	2.08 MiB

github-actions · 2024-02-12T22:08:06Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1203.10 ms	1205.89 ms	2.79 ms
Size	2.36 MiB	2.90 MiB	553.31 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`728164b`+dirty	1256.10 ms	1259.08 ms	2.98 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`12427f4`+dirty	1267.15 ms	1271.30 ms	4.15 ms
`2534337`+dirty	1225.08 ms	1230.26 ms	5.17 ms

App size

Revision	Plain	With Sentry	Diff
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`728164b`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`12427f4`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`2534337`+dirty	2.36 MiB	2.88 MiB	525.47 KiB

github-actions · 2024-02-13T11:07:37Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	370.81 ms	414.90 ms	44.09 ms
Size	7.15 MiB	8.18 MiB	1.03 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`0677344`+dirty	288.40 ms	391.44 ms	103.04 ms
`9433f35`+dirty	265.50 ms	336.08 ms	70.58 ms
`b1e8712`+dirty	322.55 ms	331.84 ms	9.29 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`9c48b2c`+dirty	270.82 ms	321.12 ms	50.30 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`22e31b6`+dirty	295.75 ms	346.73 ms	50.98 ms

App size

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`0677344`+dirty	7.15 MiB	8.07 MiB	949.80 KiB
`9433f35`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`b1e8712`+dirty	7.15 MiB	8.04 MiB	912.27 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`9c48b2c`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`22e31b6`+dirty	7.15 MiB	8.10 MiB	981.29 KiB

github-actions · 2024-02-13T12:54:10Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.94 ms	1215.20 ms	0.27 ms
Size	2.92 MiB	3.46 MiB	557.68 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`e5c9b8b`+dirty	1276.90 ms	1280.92 ms	4.02 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`728164b`+dirty	1280.06 ms	1285.26 ms	5.20 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`12427f4`+dirty	1224.90 ms	1231.40 ms	6.50 ms
`2534337`+dirty	1220.87 ms	1221.47 ms	0.60 ms

App size

Revision	Plain	With Sentry	Diff
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`e5c9b8b`+dirty	2.92 MiB	3.43 MiB	524.50 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`728164b`+dirty	2.92 MiB	3.44 MiB	533.26 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`12427f4`+dirty	2.92 MiB	3.44 MiB	533.29 KiB
`2534337`+dirty	2.92 MiB	3.43 MiB	529.76 KiB

Fix sample app ios build

7b8b220

remove cocoapod action

aa81336

This was referenced Feb 13, 2024

feat(sdk): Add JS Core metrics #3590

Merged

chore(deps): update JavaScript SDK to v7.100.1 #3589

Merged

krystofwoldrich added 2 commits February 13, 2024 11:38

enforce exact cocoa pods version

d518be8

tmp disable cache

d724563

krystofwoldrich added 5 commits February 13, 2024 12:16

use bundle exec pod install

dd4ecdc

enable auto bundler install

dc11eaf

fix e2e tests pod install

32c3274

set exact cocoapods version for e2e tests

66a766e

dynamically change pod install command e2e tests based on rn version

08f5943

krystofwoldrich requested review from brustolin and philipphofmann February 13, 2024 12:46

krystofwoldrich marked this pull request as ready for review February 13, 2024 12:46

krystofwoldrich requested a review from lucas-zimerman as a code owner February 13, 2024 12:46

brustolin approved these changes Feb 13, 2024

View reviewed changes

krystofwoldrich merged commit bab71cf into main Feb 13, 2024

krystofwoldrich deleted the @krystofwoldrich/fix-ios-cocoapods-ci branch February 13, 2024 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ci): Fix iOS builds failing Hermes cocoapods #3592

fix(ci): Fix iOS builds failing Hermes cocoapods #3592

Uh oh!

krystofwoldrich commented Feb 12, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 12, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 12, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2024

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2024

Baseline results on branch: main

Startup times

App size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(ci): Fix iOS builds failing Hermes cocoapods #3592

fix(ci): Fix iOS builds failing Hermes cocoapods #3592

Uh oh!

Conversation

krystofwoldrich commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2024

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Feb 13, 2024

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

krystofwoldrich commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading