feat(profiling): Send debug information with Profiles #3343

krystofwoldrich · 2023-10-13T14:12:07Z

📢 Type of change

New feature

📜 Description

Add debug meta images to profile events to enabled symbolication on Sentry backend.

💚 How did you test it?

sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties) sentry-javascript#9277

…symbolicated-profiles

github-actions · 2023-10-13T14:13:14Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0dcaa07

github-actions · 2023-10-13T14:32:21Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	415.54 ms	430.47 ms	14.93 ms
Size	17.73 MiB	19.86 MiB	2.12 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`0677344`	327.74 ms	337.14 ms	9.40 ms
`d7401ac`+dirty	375.20 ms	383.51 ms	8.31 ms
`457e29f`	398.10 ms	421.39 ms	23.29 ms
`9c48b2c`	349.24 ms	385.96 ms	36.72 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms

App size

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`0677344`	17.73 MiB	19.81 MiB	2.07 MiB
`d7401ac`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`457e29f`	17.73 MiB	19.84 MiB	2.10 MiB
`9c48b2c`	17.73 MiB	19.80 MiB	2.07 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

Previous results on branch: kw-symbolicated-profiles

Startup times

Revision	Plain	With Sentry	Diff
`10896ec`	436.48 ms	455.94 ms	19.46 ms

App size

Revision	Plain	With Sentry	Diff
`10896ec`	17.73 MiB	19.85 MiB	2.12 MiB

…symbolicated-profiles

github-actions · 2023-10-13T17:42:46Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1228.72 ms	1229.28 ms	0.56 ms
Size	2.36 MiB	2.88 MiB	533.14 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`5446992`+dirty	1273.28 ms	1276.68 ms	3.40 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`ad6c299`+dirty	1244.76 ms	1260.10 ms	15.34 ms

App size

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`5446992`+dirty	2.36 MiB	2.88 MiB	531.94 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`ad6c299`+dirty	2.36 MiB	2.84 MiB	488.85 KiB

Previous results on branch: kw-symbolicated-profiles

Startup times

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	1262.08 ms	1269.52 ms	7.44 ms

App size

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	2.36 MiB	2.88 MiB	532.15 KiB

github-actions · 2023-10-13T17:46:15Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1299.88 ms	1312.06 ms	12.18 ms
Size	2.92 MiB	3.44 MiB	536.47 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`5446992`+dirty	1249.94 ms	1254.80 ms	4.86 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`ad6c299`+dirty	1248.50 ms	1248.88 ms	0.38 ms

App size

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`5446992`+dirty	2.92 MiB	3.44 MiB	535.26 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`ad6c299`+dirty	2.92 MiB	3.40 MiB	494.12 KiB

Previous results on branch: kw-symbolicated-profiles

Startup times

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	1295.76 ms	1307.16 ms	11.40 ms

App size

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	2.92 MiB	3.44 MiB	535.45 KiB

github-actions · 2023-10-13T17:55:36Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	376.52 ms	395.56 ms	19.04 ms
Size	7.15 MiB	8.13 MiB	1002.12 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`0db0c72`+dirty	335.20 ms	351.06 ms	15.86 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms

App size

Revision	Plain	With Sentry	Diff
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`0db0c72`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB

Previous results on branch: kw-symbolicated-profiles

Startup times

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	345.59 ms	374.26 ms	28.67 ms

App size

Revision	Plain	With Sentry	Diff
`10896ec`+dirty	7.15 MiB	8.12 MiB	999.77 KiB

krystofwoldrich added 10 commits October 11, 2023 13:18

feat(profiling): Send debug information with Profiles

7dff905

fix white space

f147e93

Add support for Hermes bytecode frames

5561dc7

Add changelog

fd0876e

Use bundle filename to lookup debugid

7e964ce

Remove unnecessary lookup logic as only one bundle is supported

073450f

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

22eabf0

…symbolicated-profiles

Fix build

affcee8

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

143d6e2

…symbolicated-profiles

Fix build

5dd4ea7

krystofwoldrich changed the base branch from main to kw-add-hermes-profile-bytecode-frames-parsing October 13, 2023 14:12

krystofwoldrich requested a review from JonasBa October 13, 2023 14:15

krystofwoldrich added 4 commits October 13, 2023 16:51

fix lint

81c2acb

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

c3683f4

…symbolicated-profiles

fix lint

729876e

change profile platform to javascript

7d608fb

JonasBa approved these changes Oct 13, 2023

View reviewed changes

Mark root as in app false

102f1f1

Base automatically changed from kw-add-hermes-profile-bytecode-frames-parsing to main October 17, 2023 17:58

krystofwoldrich added 3 commits October 18, 2023 13:06

Use abs_path like error stacktrace frames

7e33cfa

Merge remote-tracking branch 'origin/main' into kw-symbolicated-profiles

66c2d58

Fix tests

4b1c004

krystofwoldrich marked this pull request as ready for review October 19, 2023 13:29

krystofwoldrich requested a review from lucas-zimerman as a code owner October 19, 2023 13:29

remove duplicate types

facf3ed

krystofwoldrich added 2 commits October 27, 2023 12:23

Merge remote-tracking branch 'origin/main' into kw-symbolicated-profiles

fff24a0

Update changelog

0dcaa07

krystofwoldrich merged commit 1b92a08 into main Oct 27, 2023

krystofwoldrich deleted the kw-symbolicated-profiles branch October 27, 2023 12:27

Uh oh!

feat(profiling): Send debug information with Profiles #3343

feat(profiling): Send debug information with Profiles #3343

Uh oh!

Conversation

krystofwoldrich commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-symbolicated-profiles

Startup times

App size

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-symbolicated-profiles

Startup times

App size

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-symbolicated-profiles

Startup times

App size

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-symbolicated-profiles

Startup times

App size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krystofwoldrich commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading