fix(sdk): Rename app start measurements to match other SDKs #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
added
the
Breaking-change
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
| 9a3ca65+dirty | 326.93 ms | 330.14 ms | 3.21 ms |
| 86d6d2c+dirty | 332.90 ms | 352.45 ms | 19.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 9a3ca65+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 86d6d2c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 1217.61 ms | 1242.66 ms | 25.05 ms |
| 9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
| 86d6d2c+dirty | 1267.55 ms | 1286.21 ms | 18.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 2.36 MiB | 2.82 MiB | 462.86 KiB |
| 9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
| 86d6d2c+dirty | 2.36 MiB | 2.82 MiB | 462.82 KiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 1234.80 ms | 1249.20 ms | 14.40 ms |
| 9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
| 86d6d2c+dirty | 1291.62 ms | 1296.80 ms | 5.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 2.92 MiB | 3.37 MiB | 464.41 KiB |
| 9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
| 86d6d2c+dirty | 2.92 MiB | 3.37 MiB | 464.31 KiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 258.75 ms | 313.61 ms | 54.86 ms |
| 9a3ca65+dirty | 344.96 ms | 358.92 ms | 13.96 ms |
| 86d6d2c+dirty | 267.21 ms | 325.24 ms | 58.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 7.15 MiB | 8.09 MiB | 962.72 KiB |
| 9a3ca65+dirty | 7.15 MiB | 8.09 MiB | 962.83 KiB |
| 86d6d2c+dirty | 7.15 MiB | 8.09 MiB | 962.69 KiB |
krystofwoldrich
removed
the
Breaking-change
marandaneto
reviewed
Feb 27, 2023
…sentry/sentry-react-native into kw-fix-app-start-measurements-naming
11 tasks
marandaneto
approved these changes
Mar 2, 2023
Contributor
marandaneto
left a comment
marandaneto
left a comment
There was a problem hiding this comment.
Thanks @krystofwoldrich
|
@krystofwoldrich Are you planning on shipping this in the Thanks for the fix |
Contributor
Author
|
@fabiendem As the start-up times from the v4 can be viewed as custom measurements if your plan supports it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Renames the
app start measurementtoapp_start_warmand keeps theopasapp.start.warmto be aligned with the other mobile SDK.💡 Motivation and Context
Although the mentioned issue is closed and the main cause of the long
app start timewas resolved inI believe users are seeing
app start timesonly till sdk version4.5.0as the measurement was renamed from
app_start_warmtoapp.start.warm.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps