Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 28, 2022

📜 Description

Bump: @sentry/javascript dependencies to 6.19.2

For PR review, focus on 7655547
The rest is lint fixes.

💡 Motivation and Context

Bug fixes getsentry/sentry-javascript#4531 and getsentry/sentry-javascript#4614

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Comment on lines +63 to +64
// release: '[email protected]+1',
// dist: `1`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennmueng do you remember why did we hard-coded the release and dist in the samples? that makes our sample symbolication not work automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marandaneto That was just to provide an example of the option being used I think

@marandaneto marandaneto requested a review from AbhiPrasad March 28, 2022 08:40
@marandaneto marandaneto requested a review from jennmueng March 28, 2022 09:20
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto enabled auto-merge (squash) March 29, 2022 07:32
@marandaneto marandaneto merged commit f916f2b into main Mar 29, 2022
@marandaneto marandaneto deleted the bump/sentry-js branch March 29, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants