Skip to content

Conversation

@marshall-lee
Copy link
Contributor

Fixes #920.

@untitaker
Copy link
Member

You added a test matrix for 1.9 which appears to pass, including all assertions. I would've expected that those raise DidNotEnable. I suspect this is because pkg_resources is not actually installed.

I recommend two things:

  • I'd parse the version manually with tuple(map(str, like in other integrations to remove the pkg_resources dependency. At the moment a user does not have pkg_resources installed, the SDK will effectively crash unless they also have boto3 installed.
  • Decide on the lowest boto3 version we want to support. It seems the tests run fine with 1.9 while we say we support 1.12+.

@untitaker
Copy link
Member

@marshall-lee can you look into this again?

@marshall-lee
Copy link
Contributor Author

@untitaker

I changed the version check code.

Decide on the lowest boto3 version we want to support. It seems the tests run fine with 1.9 while we say we support 1.12+.

There's some confusion with boto3 library versions.

There're two libraries — user-facing boto3 and its "core" package botocore. We run tests against different boto3 versions but the integration itself does its job on botocore level. Perhaps it was better to name it BotocoreIntegration instead of Boto3Integration.

So, the minimum boto3 version on test matrix is 1.9 but it uses botocore version 1.12.

@untitaker
Copy link
Member

CI randomly locks up. Probably something else.

@untitaker untitaker merged commit 5a41127 into getsentry:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not working with older boto version

2 participants