Skip to content

Conversation

sentrivana
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.69%. Comparing base (567a91a) to head (5d677d4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4777      +/-   ##
==========================================
+ Coverage   84.61%   84.69%   +0.07%     
==========================================
  Files         158      158              
  Lines       16376    16376              
  Branches     2809     2809              
==========================================
+ Hits        13857    13869      +12     
+ Misses       1693     1684       -9     
+ Partials      826      823       -3     

see 4 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 8, 2025 07:54
@sentrivana sentrivana requested a review from a team as a code owner September 8, 2025 07:54
@sentrivana sentrivana enabled auto-merge (squash) September 8, 2025 07:56
Comment on lines +208 to 209
{py3.9,py3.12,py3.13}-gql-v4.2.0b0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The GQL integration will crash with gql>=4.2.0b0 because client.execute now passes a GraphQLRequest object, but the integration expects a DocumentNode.
  • Description: The update to gql>=4.2.0b0 introduces a breaking change where client.execute receives a GraphQLRequest object instead of a DocumentNode. The Sentry integration's patched execute method passes this object to _data_from_document, which expects a DocumentNode. This will cause a runtime crash when helper functions like get_operation_ast(document) are called with the wrong object type. This will affect all users of the GQL integration who upgrade to the new version and make any GraphQL request.

  • Suggested fix: In the patched execute method, check if the document argument is an instance of GraphQLRequest. If so, extract the DocumentNode from its .document attribute before passing it to the _data_from_document function. This will restore compatibility with the new gql version's API.
    severity: 0.85, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a real concern, though it's already in 4.0.0. I'll make a separate PR for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sentrivana sentrivana merged commit bdf3e6d into master Sep 8, 2025
129 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/regular-update branch September 8, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants