Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 5, 2025

chalice was the last test suite in the Cloud group that was still hardcoded, so moving it under toxgen also gets rid of the whole latest group 🎉

Ref #4506

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (ad3c435) to head (5726160).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4766       +/-   ##
===========================================
+ Coverage   32.11%   84.78%   +52.66%     
===========================================
  Files         158      158               
  Lines       16323    16323               
  Branches     2588     2792      +204     
===========================================
+ Hits         5242    13839     +8597     
+ Misses      10575     1668     -8907     
- Partials      506      816      +310     

see 133 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 5, 2025 08:56
@sentrivana sentrivana requested a review from a team as a code owner September 5, 2025 08:56
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@szokeasaurusrex
Copy link
Member

Just confirming understanding – the reason we get rid of the latest group here is that toxgen will automatically always also include a pinned version of whatever the latest version of chalice is, when we run the toxgen script?

@sentrivana
Copy link
Contributor Author

Just confirming understanding – the reason we get rid of the latest group here is that toxgen will automatically always also include a pinned version of whatever the latest version of chalice is, when we run the toxgen script?

Exactly.

@sentrivana sentrivana merged commit 7d7c8ea into master Sep 5, 2025
136 of 138 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/chalice branch September 5, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants