Skip to content

Add empty tags by default to transaction #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

sl0thentr0py
Copy link
Member

Seems like some before_sends out there might assume tags without safe access as we found out during dogfooding.

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner August 7, 2025 12:01
cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.97%. Comparing base (53005b9) to head (5075d22).
⚠️ Report is 3 commits behind head on potel-base.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4683      +/-   ##
==============================================
- Coverage       85.01%   84.97%   -0.05%     
==============================================
  Files             158      158              
  Lines           15540    15541       +1     
  Branches         2461     2461              
==============================================
- Hits            13212    13206       -6     
- Misses           1572     1579       +7     
  Partials          756      756              
Files with missing lines Coverage Δ
sentry_sdk/opentelemetry/span_processor.py 82.65% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py changed the title Add empty tags by default Add empty tags by default to transaction Aug 7, 2025
@sl0thentr0py sl0thentr0py merged commit 1ddb232 into potel-base Aug 7, 2025
125 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/add-empty-tags branch August 7, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants