-
Notifications
You must be signed in to change notification settings - Fork 556
Add enable_logs
, before_send_log
as top-level options
#4644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
+ Coverage 80.75% 80.79% +0.03%
==========================================
Files 156 156
Lines 16635 16643 +8
Branches 2831 2833 +2
==========================================
+ Hits 13434 13446 +12
+ Misses 2311 2306 -5
- Partials 890 891 +1
|
# type: (Optional[Log]) -> None | ||
if not has_logs_enabled(self.options) or log is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here because mypy was complaining about log
not being Optional
on line 962 (in the new diff) and the get_before_send_log
function potentially returning None
🙄
Promote
enable_logs
andbefore_send_log
to regular (non-experimental) SDK options. Keep supporting the experimental versions too, for backwards compat.Closes #4641