Skip to content

ref(spotlight): Do not import sentry_sdk.spotlight unless enabled #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

sentrivana
Copy link
Contributor

Closes #4605

@sentrivana sentrivana changed the title ref(spotlight): Do not import sentry_sdk.spotlight unless enabled ref(spotlight): Do not import sentry_sdk.spotlight unless enabled Jul 22, 2025
@sentrivana sentrivana marked this pull request as ready for review July 22, 2025 08:00
@sentrivana sentrivana requested a review from a team as a code owner July 22, 2025 08:00
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (0e73049) to head (2d3fc8c).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4607      +/-   ##
==========================================
+ Coverage   80.64%   80.66%   +0.01%     
==========================================
  Files         156      156              
  Lines       16500    16500              
  Branches     2806     2806              
==========================================
+ Hits        13307    13309       +2     
  Misses       2304     2304              
+ Partials      889      887       -2     
Files with missing lines Coverage Δ
sentry_sdk/client.py 78.80% <100.00%> (ø)

... and 3 files with indirect coverage changes

@sentrivana sentrivana merged commit 24790eb into master Jul 22, 2025
137 checks passed
@sentrivana sentrivana deleted the ivana/dont-import-spotlight-if-not-enabled branch July 22, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry_sdk.spotlight adds 11mb to RSS regardless of whether it is used
2 participants