Skip to content

breakpoints/debug printing for Django ASGI investigation #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

breakpoints/debug printing for Django ASGI investigation #3164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,9 @@ def capture_event(
if self.transport is None:
return None

if is_transaction:
breakpoint()

self.transport.capture_envelope(envelope)

return event_id
Expand Down
1 change: 1 addition & 0 deletions sentry_sdk/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ def __enter__(self):

def __exit__(self, ty, value, tb):
# type: (Optional[Any], Optional[Any], Optional[Any]) -> None
breakpoint()
if value is not None:
self.set_status("internal_error")

Expand Down
1 change: 1 addition & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ def inner():
def append_event(envelope):
for item in envelope:
if item.headers.get("type") in ("event", "transaction"):
print(f"append_event: {item}")
events.append(item.payload.json)
return old_capture_envelope(envelope)

Expand Down
18 changes: 10 additions & 8 deletions tests/integrations/django/asgi/test_asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ async def test_has_trace_if_performance_disabled(sentry_init, capture_events):


@pytest.mark.asyncio
@pytest.mark.forked
# @pytest.mark.forked
@pytest.mark.skipif(
django.VERSION < (3, 1), reason="async views have been introduced in Django 3.1"
)
Expand All @@ -338,18 +338,20 @@ async def test_trace_from_headers_if_performance_enabled(sentry_init, capture_ev
response = await comm.get_response()
assert response["status"] == 500

assert len(events) == 3

# ASGI Django does not create transactions per default,
# so we do not have a transaction_event here.
(msg_event, error_event) = events
# (msg_event, error_event) = events

assert msg_event["contexts"]["trace"]
assert "trace_id" in msg_event["contexts"]["trace"]
# assert msg_event["contexts"]["trace"]
# assert "trace_id" in msg_event["contexts"]["trace"]

assert error_event["contexts"]["trace"]
assert "trace_id" in error_event["contexts"]["trace"]
# assert error_event["contexts"]["trace"]
# assert "trace_id" in error_event["contexts"]["trace"]

assert msg_event["contexts"]["trace"]["trace_id"] == trace_id
assert error_event["contexts"]["trace"]["trace_id"] == trace_id
# assert msg_event["contexts"]["trace"]["trace_id"] == trace_id
# assert error_event["contexts"]["trace"]["trace_id"] == trace_id


@pytest.mark.asyncio
Expand Down