Skip to content

fix(docs): allow empty character in metric tags values #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix(docs): allow empty character in metric tags values #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2214772
allow empty char in tags values
viglia Feb 28, 2024
0ed2678
add expty space test
viglia Feb 28, 2024
ce938d9
address suggestion
viglia Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@

_in_metrics = ContextVar("in_metrics", default=False)
_sanitize_key = partial(re.compile(r"[^a-zA-Z0-9_/.-]+").sub, "_")
_sanitize_value = partial(re.compile(r"[^\w\d_:/@\.{}\[\]$-]+", re.UNICODE).sub, "")
_sanitize_value = partial(re.compile(r"[^\w\d\s_:/@\.{}\[\]$-]+", re.UNICODE).sub, "")
_set = set # set is shadowed below

GOOD_TRANSACTION_SOURCES = frozenset(
Expand Down
8 changes: 7 additions & 1 deletion tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,7 @@ def test_tag_normalization(
metrics.distribution("a", 1.0, tags={"foo-bar": "%$foo"}, timestamp=ts)
metrics.distribution("b", 1.0, tags={"foo$$$bar": "blah{}"}, timestamp=ts)
metrics.distribution("c", 1.0, tags={u"foö-bar": u"snöwmän"}, timestamp=ts)
metrics.distribution("d", 1.0, tags={"route": "GET /foo"}, timestamp=ts)
# fmt: on
Hub.current.flush()

Expand All @@ -820,7 +821,7 @@ def test_tag_normalization(
assert envelope.items[0].headers["type"] == "statsd"
m = parse_metrics(envelope.items[0].payload.get_bytes())

assert len(m) == 3
assert len(m) == 4
assert m[0][4] == {
"foo-bar": "$foo",
"release": "[email protected]",
Expand All @@ -839,6 +840,11 @@ def test_tag_normalization(
"release": "[email protected]",
"environment": "not-fun-env",
}
assert m[3][4] == {
"release": "[email protected]",
"environment": "not-fun-env",
"route": "GET /foo",
}
# fmt: on


Expand Down