Skip to content

Fix performance regression in utils._generate_installed_modules #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix performance regression in utils._generate_installed_modules #2703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a61fb67
Fix performance regression in sentry_sdk.utils._generate_installed_mo…
GlenWalker Feb 4, 2024
0860cb2
Merge branch 'master' into master
sentrivana Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,16 +1666,18 @@ def _generate_installed_modules():
try:
from importlib import metadata

yielded = set()
for dist in metadata.distributions():
name = dist.metadata["Name"]
# `metadata` values may be `None`, see:
# https://github.com/python/cpython/issues/91216
# and
# https://github.com/python/importlib_metadata/issues/371
if name is not None:
version = metadata.version(name)
if version is not None:
yield _normalize_module_name(name), version
normalized_name = _normalize_module_name(name)
if dist.version is not None and normalized_name not in yielded:
yield normalized_name, dist.version
yielded.add(normalized_name)

except ImportError:
# < py3.8
Expand Down