Skip to content

Move importorskips in tests to __init__.py files #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2023
Merged

Move importorskips in tests to __init__.py files #2412

merged 4 commits into from
Oct 4, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 4, 2023 •
edited
Loading

In CONTRIBUTING.md we say:

Create a new folder in tests/integrations/, with an init file that skips the entire suite if the package is not installed.

but we're not following this everywhere ourselves. Not that it matters too much, but let's make it consistent.

@sentrivana sentrivana changed the title Ivana/move importorskips Move importorskips in tests to __init__.py files Oct 4, 2023
@sentrivana sentrivana marked this pull request as ready for review October 4, 2023 12:16
@sentrivana sentrivana enabled auto-merge (squash) October 4, 2023 12:16
@sentrivana sentrivana merged commit 963e0d5 into master Oct 4, 2023
@sentrivana sentrivana deleted the ivana/move-importorskips branch October 4, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @cleptric