Context manager monitor #2290
Merged
Context manager monitor #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Great job! You are now officially a decorator expert. 🎖️
I've left two comments, please have a look and address before merging.
Other than that, we also need to update the documentation, this page specifically. There's a Suggest an edit to this page link on the very bottom of each docs page that takes you to the source and allows you to directly create a PR to sentry-docs. Alternatively, you can clone https://github.com/getsentry/sentry-docs/, make the changes locally and create a PR as you would for this repo. Someone from our team should then have a look as well as a member of the docs team.
|
We can also create the docs PR together tomorrow if you prefer. |
sentrivana
approved these changes
Aug 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
monitordecorator can now also be used as a context manager (with thewithstatement). This PR implements #2273.