Skip to content

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Apr 25, 2023

This PR updates handling of data in the redis SDK:

  • Arguments of the redis AUTH command is never collected (because it contains username and password)
  • When send_default_pii=False the arguments of all redis commands are redacted (except the first parameter, because it is always the "key" and thus important for debugging
  • Span descriptions and breadcrumb message are truncated to a max size of 1024 (the max size can be configured in a new argument to RedisIntegration(max_data_size=30) (if max_data_size is set to a falsie value (0 or None) then no truncation is done)

Fixes #2023

@antonpirker antonpirker marked this pull request as ready for review April 25, 2023 07:34
@antonpirker antonpirker self-assigned this Apr 25, 2023
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I believe keys can also contain PII, like user ids and such, though probably not security sensitive things.

@antonpirker antonpirker merged commit 3255a93 into master Apr 25, 2023
@antonpirker antonpirker deleted the antonpirker/fix-redis-span-data branch April 25, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not add redis SET data in span description when set_default_pii=False

3 participants