Skip to content

Add API to set arbitrary context in Transaction. #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add API to set arbitrary context in Transaction. #1769

merged 2 commits into from
Nov 30, 2022

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Nov 30, 2022

No description provided.

@antonpirker antonpirker added this to the Basic OTel support milestone Nov 30, 2022
@antonpirker antonpirker mentioned this pull request Nov 30, 2022
Closed
@sl0thentr0py sl0thentr0py changed the base branch from master to antonpirker/1687-basic-otel-support-2-instrumenter November 30, 2022 13:59
sl0thentr0py
sl0thentr0py requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be on Transaction, not Span

@antonpirker antonpirker changed the title Add API to set arbitrary context in Span. Add API to set arbitrary context in Transaction. Nov 30, 2022
@antonpirker antonpirker force-pushed the antonpirker/1687-basic-otel-support-3a-set-context branch from 5519e7b to 89e554b Compare November 30, 2022 15:33
@antonpirker
Copy link
Contributor Author

antonpirker commented Nov 30, 2022

Oh, did not know that, but makes sense. Changed it.

@antonpirker antonpirker merged commit 7a8654e into antonpirker/1687-basic-otel-support-2-instrumenter Nov 30, 2022
@antonpirker antonpirker deleted the antonpirker/1687-basic-otel-support-3a-set-context branch November 30, 2022 15:53
antonpirker added a commit that referenced this pull request Dec 1, 2022
@antonpirker
Add instrumenter config to switch between Otel and Sentry instrumenta…
46697dd 
…tion. (#1766)

* Add instrumenter config to switch between Sentry and OTel instrumentation.
* Add API to set arbitrary context in Transaction. (#1769)
* Add API to set custom Span timestamps (#1770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Basic OTel support

Development

Successfully merging this pull request may close these issues.

3 participants

@antonpirker @sl0thentr0py